Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist libresolv? #80

Closed
bluetech opened this issue Aug 24, 2017 · 3 comments
Closed

Whitelist libresolv? #80

bluetech opened this issue Aug 24, 2017 · 3 comments

Comments

@bluetech
Copy link

@bluetech bluetech commented Aug 24, 2017

This library is part of glibc (similarly to libc, libm, librt, libpthread etc which are already whitelisted) and uses the same symbol versioning. I wonder if perhaps it is better not to bundle it?

Context: I ran into some trouble with the psycopg2 wheel, please see the details here: psycopg/psycopg2-wheels#2. If I replace the bundled version with the system version it works fine.

@njsmith
Copy link
Member

@njsmith njsmith commented Aug 24, 2017

That does look like an oversight, yeah.

I guess the todo list for whitelisting it would be:

  • Update the PEP – should be a pretty trivial PR to the python/peps repository
  • Update the auditwheel policy – should be a pretty trivial PR to pypa/auditwheel

Are you interested in taking this on?

@bluetech
Copy link
Author

@bluetech bluetech commented Aug 24, 2017

Are you interested in taking this on?

I am not very familiar with the subject matter (I hadn't even realized this was specified in a PEP), and have stopped using manylinux wheels personally, so hopefully someone else would formally propose this change.

Thanks!

dvarrazzo added a commit to psycopg/psycopg2-wheels that referenced this issue Aug 25, 2017
dvarrazzo added a commit to dvarrazzo/auditwheel that referenced this issue Aug 25, 2017
dvarrazzo added a commit to dvarrazzo/peps that referenced this issue Aug 25, 2017
@dvarrazzo
Copy link
Contributor

@dvarrazzo dvarrazzo commented Aug 25, 2017

I've sent MR around to update the policy and the PEP as per comment. Let me know if there's anything else to do.

In the meantime I've fixed auditwheels locally to whitelist libresolv and release a fixed version of the psycopg2 package: the OP tested the package and reported it working ok.

dvarrazzo added a commit to dvarrazzo/peps that referenced this issue Aug 25, 2017
brettcannon added a commit to python/peps that referenced this issue Aug 28, 2017
dvarrazzo added a commit to dvarrazzo/auditwheel that referenced this issue Nov 16, 2017
@ehashman ehashman closed this in #81 Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants