Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max_versioned_symbol, fix version policy check #43

Merged
merged 4 commits into from Jun 4, 2016

Conversation

@ehashman
Copy link
Member

ehashman commented Jun 4, 2016

Hopefully fixes #41 (and definitely #42).

ehashman added 4 commits Jun 4, 2016
Lists of versions were generated from the .gnu.version_d sections of the
lib_whitelist .so's available in the manylinux docker image.
@ehashman ehashman force-pushed the ehashman:issue-41 branch from 7143074 to 5ffc3c6 Jun 4, 2016
@ehashman ehashman changed the title Remove max_versioned_symbol, fix symbol policy check Remove max_versioned_symbol, fix version policy check Jun 4, 2016
@njsmith

This comment has been minimized.

Copy link
Member

njsmith commented Jun 4, 2016

Noting for the record, the main change here is that instead of trying to parse the version strings to convert them into sortable numbers -- which is sorta unfortunate since they're really arbitrary tokens -- this changes the policy to just have a list of which version string tokens are allowed. This makes things simpler and more correct.

@njsmith njsmith merged commit 952b9f5 into pypa:master Jun 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ehashman

This comment has been minimized.

Copy link
Member Author

ehashman commented Jun 4, 2016

For the record, sketchy way I used to generate the list of versions on the manylinux docker:

(in manylinux docker with libs from lib_whitelist)# for lib in "libpanelw.so.5" "libncursesw.so.5" "libgcc_s.so.1" "libstdc++.so.6" "libm.so.6" "libdl.so.2" "librt.so.1" "libcrypt.so.1" "libc.so.6" "libnsl.so.1" "libutil.so.1" "libpthread.so.0" "libX11.so.6" "libXext.so.6" "libXrender.so.1" "libICE.so.6" "libSM.so.6" "libGL.so.1" "libgobject-2.0.so.0" "libgthread-2.0.so.0" "libglib-2.0.so.0"; do readelf -V `ldconfig -p | grep $lib | sed 's|.*=> ||'` >> /versions.txt; done

$ docker cp silly_hamilton:/versions.txt symbols.txt
$ vim symbols.txt
<removed any non-.gnu.version_d sections>
$ grep 'Name:' symbols.txt > symbols2.txt  # gets only lines with version names
$ grep -v 'Name: .*\.so' symbols2.txt | awk '{ print $11 }' | sort -u  # removes version names corresponding to .so's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.