-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Work-in-progress) Update config file reading and validation #1694
Closed
Commits on Apr 1, 2024
-
Fix custom config reference syntax for
diff-file
This replaces the implementation for custom configparser option references in the diff-file option. Moves detection and handling for the custom syntax into a dedicated submodule. Uses a regular expression to preserve text before and after the reference.
Configuration menu - View commit details
-
Copy full SHA for e4668e1 - Browse repository at this point
Copy the full SHA e4668e1View commit details -
Fix diff-file being written unconditionally.
Restore original behavior where a diff file is only written if the 'mirror.diff-file' config option is set to a non-empty value.
Configuration menu - View commit details
-
Copy full SHA for 7784f06 - Browse repository at this point
Copy the full SHA 7784f06View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3b23b0 - Browse repository at this point
Copy the full SHA b3b23b0View commit details -
Refactoring of Storage and Bander...Mirror inits
Change the Storage base class and the storage plugin loading functions to require a ConfigParser instance so the BandersnatchConfig singleton is not accessed. Change the BandersnatchMirror class to require a Storage instance instead of a storage backend name since the mirror subcommand already loads a storage plugin instance. The diff in the application code is relatively simple, but both changes caused cascading/rippling updates to the unit tests that will require a regrettable amount of tedious review. It would be nice to find a way to split up this commit.
Configuration menu - View commit details
-
Copy full SHA for 7cdbfe2 - Browse repository at this point
Copy the full SHA 7cdbfe2View commit details -
Refactoring of Filter & Mirror initialization
Change the Filter base class and filter loader to require an external ConfigParser instance be passed in. Change the Mirror/BandersnatchMirror classes to require an external instance of LoadedFilters. op/ed: Remember all that nonsense you told yourself about removing a singleton making the tests simpler? Well so far that is not the case.
Configuration menu - View commit details
-
Copy full SHA for ef2e388 - Browse repository at this point
Copy the full SHA ef2e388View commit details -
Configuration menu - View commit details
-
Copy full SHA for eadc324 - Browse repository at this point
Copy the full SHA eadc324View commit details
Commits on Apr 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9e6244f - Browse repository at this point
Copy the full SHA 9e6244fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0030683 - Browse repository at this point
Copy the full SHA 0030683View commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for df9d88a - Browse repository at this point
Copy the full SHA df9d88aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.