tests: better isolate test_venv_fail #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjni
requested review from
FFY00,
gaborbernat,
layday and
henryiii
as code owners
13 tasks
layday
approved these changes
Oct 4, 2022
henryiii
approved these changes
Oct 4, 2022
layday
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nixpkgs, we run the tests in parallel using
pytest-xdist, and I can consistently see a failure on my M1 Mac machine intest_main.py#test_venv_failrelated to the actual stdout containing color escape sequences when none were expected.If I reload
build.__main__as is done in other tests, the failure goes away for me.