Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IsolatedEnv, take two #537

Merged
merged 8 commits into from
Jan 25, 2023
Merged

Refactor IsolatedEnv, take two #537

merged 8 commits into from
Jan 25, 2023

Commits on Jan 25, 2023

  1. build: factor out exceptions and utils to prevent import cycles

    @layday
    layday committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    cbb5273 View commit details
    Browse the repository at this point in the history

  2. build: move wheel name regex to utils

    @layday
    layday committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8c6c2d5 View commit details
    Browse the repository at this point in the history

  3. env: redefine isolated env interface 

    - `install` is not required to interface with the backend --
  consumers can provision the isolated env in whichever manner
  they see fit.
- Assume responsibility for mutating `os.environ` -- different
  isolated envs may need to modify different env vars.
  As a consequence, the `scripts_dir` does not
  need to be exposed to the `ProjectBuilder`.
    @layday
    layday committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    808a13c View commit details
    Browse the repository at this point in the history

  4. env: make the isolated env a protocol in Python 3.8+

    @layday
    layday committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    6f6bf92 View commit details
    Browse the repository at this point in the history

  5. build: add builder from_isolated_env constructor 

    Reorganised the `ProjectBuilder` to accommodate the new constructor.
`scripts_dir` was removed and mutating the `python_executable` is
not supported anymore.  `srcdir` was renamed to `source_dir` to parallel
the hooks' `*_dir` params.
    @layday
    layday committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    14cfa10 View commit details
    Browse the repository at this point in the history

  6. env: combine builder and default isolated env

    @layday
    layday committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    62b8b71 View commit details
    Browse the repository at this point in the history

  7. tests: update dist files

    @layday
    layday committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    e4c27d3 View commit details
    Browse the repository at this point in the history

  8. changelog: add updated isolated env entry

    @layday
    layday committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    28c95a7 View commit details
    Browse the repository at this point in the history