-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for editable dependencies #589
Conversation
`test_editable_dependencies`
Nice work here. I'm looking into this as well, but through the amazing plugin architecture Hatch provides. Question, will this handle transitive editable dependencies? |
Internally these requirements get parsed a bit and then passed on to pip, so the behaviour is identical to what would happen if you manually installed a dependency as editable. Meaning that if you have a scenario like: [tool.hatch.envs.dev]
dependencies = [
"-e pkg_a @ {root:uri}/plugins/pkg_a",
"-e pkg_a_dep @ {root:uri}/plugins/pkg_a_dep",
...
] Then |
Okay. So the transitive editable dependencies would also need to be specified explicitly. It would be great if it could infer the transitive dependency's editable packages in some way. |
b624948
to
f95e153
Compare
f95e153
to
4a2ece5
Compare
Hey, sorry I didn't respond sooner! I've been embedding on a different team for the past 3 weeks (1 more to go). One thing I realized during this time was that rather than this approach, I'm going to implement functionality similar to Rust's workspace concept: |
No problem! That sounds interesting, I'm happy to contribute if you'd like any help. |
This is workaround to do an editable install of gitlint-core: See pypa/hatch#589 Also further refines a bunch of other CI and pyproject.toml items.
This is workaround to do an editable install of gitlint-core: See pypa/hatch#589 Also further refines a bunch of other CI and pyproject.toml items.
@RobertRosca this PR needs rebasing to pick up the CI updates. |
Closing for now #589 (comment) |
Hey, @ofek do you have some issue to track on the current topic? Do you need some support with the implementation of it? We are missing this feature quite a lot |
Rough implementation of editable dependencies as described in #588
This could probably be implemented in a better way, just a proof of concept.