Fix tests for non x86 64 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theses tests are implicitly assuming that they are being run on x86_64 or i686, but fail on ARM, PPC, etc.
dcermak
force-pushed
the
fix_tests_for_non_x86_64
branch
from
3bf8974
to
b3b81de
Compare
brettcannon
approved these changes
Aug 9, 2019
|
This PR LGTM, but I'll give other project owners a chance to review since this would be the PR I merged on this repo (plus it gives @dcermak a chance to remove the docstrings). |
|
LGTM. @brettcannon I'd merge this but I'm not gonna steal your merge from you. 🙃 |
distutils.util.get_platform() returns "linux-x86_64" on 64 bit Linux and not "linux_86_64" as assumed by this function. Instead we use the first element returned by platform.architecture() and move the check into a separate fixture. Furthermore, we have to check whether the current OS is x86-based, as the results don't match otherwise.
the else: branch was not covered in tags._linux_platforms() due to the from the previous commit
tags._mac_arch always returns i386 on 32 bit Linux and thereby tags._mac_platforms()[0] ends with "i386" even in the arch="x86_64" case
dcermak
force-pushed
the
fix_tests_for_non_x86_64
branch
from
b3b81de
to
d691f83
Compare
|
@brettcannon I've removed the pointless doc-strings. |
pradyunsg
approved these changes
Aug 11, 2019
|
Thanks, @dcermak ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling the test suite of python-packaging for opensuse, a small number of test failures popped up due to hardcoded values (e.g. "linux_x86_64" as the os arch) or wrong & untested assumptions (e.g. the test failure of
test_macos_arch_detectionon 32 bit architectures).This PR should fix these issues for ARM, PPC and s390x.
Furthermore, the detection whether the current OS is a 64 bit one was flawed (it always returned
False) and upon fixing that test coverage dropped. Therefore I have added the testtest_linux_platforms_manylinux_unsupportedto get test coverage back to 100%.