Update extlinks strings to use a format string #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx 4 added a new way of specifying extlinks "caption string" (instead of "prefix string") Sphinx 5 added a deprecation warning when still using the "prefix string" notation which fails the build: ``` Running Sphinx v5.0.1 Warning, treated as error: extlinks: Sphinx-6.0 will require a caption string to contain exactly one '%s' and all other '%' need to be escaped as '%%'. ```
pradyunsg
approved these changes
Jun 5, 2022
pradyunsg
changed the title
hrnciar
pushed a commit
to hrnciar/packaging
that referenced
this pull request
Jul 1, 2022
This addresses a warning in Sphinx 5, regarding the missing` %s` in these strings. ``` extlinks: Sphinx-6.0 will require a caption string to contain exactly one '%s' and all other '%' need to be escaped as '%%'. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 4 added a new way of specifying extlinks "caption string" (instead of "prefix string")
Sphinx 5 added a deprecation warning when still using the "prefix string" notation which fails the build: