Replace spaces in platform names with underscores

[tucked]

Resolve #652

[brettcannon]

Please add tests.

[tucked]

@brettcannon done!

[brettcannon]

I just realized there's no issue associated with this PR, so folks don't know there's a decision to be made here.

@tucked would you mind creating an issue?

[brettcannon]

@tucked I'm ready to review this again, but I still need an issue to be created so I can discuss this with the other maintainer to make sure this isn't going to be a breaking change in some way that I can't think of.

[tucked]

Hey @brettcannon, thanks for getting back to me and sorry for the delay. I've been out for the holidays.

I've created #652 and linked this PR to it! I've also rebased this PR onto the latest main.

[tucked]

It looks like a new test was added recently which breaks with this change:

packaging/tests/test_tags.py

Lines 845 to 848 in 2067970

	def test__generic_abi_jp(self, monkeypatch):
	config = {"EXT_SUFFIX": ".return exactly this.so"}
	monkeypatch.setattr(sysconfig, "get_config_var", config.__getitem__)
	assert tags._generic_abi() == ["return exactly this"]

=================================== FAILURES ===================================
_____________________ TestGenericTags.test__generic_abi_jp _____________________

self = <tests.test_tags.TestGenericTags object at 0x7fc9ff9db050>
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7fc9fa175e10>

    def test__generic_abi_jp(self, monkeypatch):
        config = {"EXT_SUFFIX": ".return exactly this.so"}
        monkeypatch.setattr(sysconfig, "get_config_var", config.__getitem__)
>       assert tags._generic_abi() == ["return exactly this"]
E       AssertionError: assert ['return_exactly_this'] == ['return exactly this']
E         At index 0 diff: 'return_exactly_this' != 'return exactly this'
E         Full diff:
E         - ['return exactly this']
E         ?         ^       ^
E         + ['return_exactly_this']
E         ?         ^       ^

tests/test_tags.py:861: AssertionError
=========================== short test summary info ============================
FAILED tests/test_tags.py::TestGenericTags::test__generic_abi_jp - AssertionError: assert ['return_exactly_this'] == ['return exactly this']
  At index 0 diff: 'return_exactly_this' != 'return exactly this'
  Full diff:
  - ['return exactly this']
  ?         ^       ^
  + ['return_exactly_this']
  ?         ^       ^
======================= 1 failed, 26341 passed in 57.45s =======================

I suppose that suggests that we may only want to normalize spaces in _generic_platforms or maybe platform_tags:

packaging/src/packaging/tags.py

Lines 483 to 496 in 2067970

	def _generic_platforms() -> Iterator[str]:
	yield _normalize_string(sysconfig.get_platform())
	def platform_tags() -> Iterator[str]:
	"""
	Provides the platform tags for this installation.
	"""
	if platform.system() == "Darwin":
	return mac_platforms()
	elif platform.system() == "Linux":
	return _linux_platforms()
	else:
	return _generic_platforms()

[brettcannon]

I suppose that suggests that we may only want to normalize spaces in _generic_platforms or maybe platform_tags

Not necessarily. It's something we can discuss as to what's best to do.

[tucked]

Not necessarily. It's something we can discuss as to what's best to do.

👌 Good to know.... I already made the adjustment from the previous diff, but we can always switch back if that ends up being the best route.

[tucked]

Based on Matti's response in #652, I've switched back to the original diff and patched the new test.

[brettcannon]

@tucked Thanks!