21.3: No longer looking for pip.conf in ~/Library/Application Support/pip/

[CMUboy]

Description

After upgrading to pip 21.3, it no longer read the configuration file in ~/Library/Application Support/pip/.

Expected behavior

Please read the configuration file in ~/Library/Application Support/pip/.

pip version

21.3

Python version

3.8.5

OS

macOS 11.6

How to Reproduce

1. Upgrade pip to 21.3
2. Put configuration in ~/Library/Application Support/pip/.
3. Observe that the configuration is not read.

Output

No response

Code of Conduct

• I agree to follow the PSF Code of Conduct.

[pradyunsg]

21.3:

env_var:
env:
global:
  /Library/Preferences/pip/pip.conf, exists: False
  /Library/Application Support/pip/pip.conf, exists: False
site:
  /Users/pradyunsg/Developer/pip/.venv/pip.conf, exists: False
user:
  /Users/pradyunsg/.pip/pip.conf, exists: False
  /Users/pradyunsg/.config/pip/pip.conf, exists: True

21.2.4:

env_var:
env:
global:
  /Library/Application Support/pip/pip.conf, exists: False
site:
  /Users/pradyunsg/Developer/pip/.venv/pip.conf, exists: False
user:
  /Users/pradyunsg/.pip/pip.conf, exists: False
  /Users/pradyunsg/.config/pip/pip.conf, exists: True

Hmm... that's not the behaviour that I see.

[pradyunsg]

We explicitly have code, to ensure that we look there:

pip/src/pip/_internal/utils/appdirs.py

Line 35 in abec8a7

return dirval.split(os.pathsep) + ["/Library/Application Support/pip"]

[pradyunsg]

What's the output of pip config debug and pip debug for you?

[uranusjr]

The path difference is probably caused by different behaviour between appdirs and platformdirs? But the report confuses me even accounting for the difference; shouldn't the Application Support directory be respected even if there's now a new directory ahead of it?

[Estartu]

Here some pip confg debug outputs

pip 21.2.4

env_var:
env:
global:
  /Library/Application Support/pip/pip.conf, exists: False
site:
  /private/tmp/test/pip.conf, exists: False
user:
  /Users/estartu/.pip/pip.conf, exists: False
  /Users/estartu/Library/Application Support/pip/pip.conf, exists: True
    global.timeout: 20
    global.upgrade-strategy: eager
    list.format: columns

pip 21.3

env_var:
env:
global:
  /Library/Preferences/pip/pip.conf, exists: False
  /Library/Application Support/pip/pip.conf, exists: False
site:
  /private/tmp/test/pip.conf, exists: False
user:
  /Users/estartu/.pip/pip.conf, exists: False
  /Users/estartu/.config/pip/pip.conf, exists: False

pip 21.3 checks the unix .config dir instead of the MacOS Application Support dir

[pradyunsg]

Ah fun. I'm able to reproduce this on my MacBook.

Not sure how we'd test this, but I think I can whip up a patch for thisnovdr the weekend.