Don't consider dist-info in a wheel as "installed" #11217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies to the new importlib.metadata backend. The legacy pkg_resources backend already does this (albeit accidentally). A package inside a wheel is not guaranteed to "work" when directly imported, so we should not treat it as an installed distribution.
uranusjr
force-pushed
the
importlib-metadata-ignore-dist-info-in-wheel
branch
from
6eebf2b
to
6eaa8e9
Compare
pfmoore
approved these changes
Jun 30, 2022
pradyunsg
approved these changes
Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to the new importlib.metadata backend. The legacy pkg_resources backend already does this (albeit accidentally).
A package inside a wheel is not guaranteed to "work" when directly imported, so we should not treat it as an installed distribution.
This fixes #11183 on our side. Note that this new logic slightly differs from the pkg_resources implementation, which blindly ignores all entries with a
.whlsuffix, while we only ignore files that actually look like a valid wheel. This means that something namedpip.whlwill not be ignored by this logic.