Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 685 #11445

Closed
1 task done
ofek opened this issue Sep 12, 2022 · 4 comments · Fixed by #12300
Closed
1 task done

Implement PEP 685 #11445

ofek opened this issue Sep 12, 2022 · 4 comments · Fixed by #12300
Labels
S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature

Comments

@ofek
Copy link
Contributor

ofek commented Sep 12, 2022

What's the problem this feature will solve?

Ensure consistency and avoid name clashing

Describe the solution you'd like

See https://peps.python.org/pep-0685/

Alternative Solutions

N/A

Additional context

Code of Conduct

@burnpanck
Copy link

This is causing a lot of trouble to people not getting their dependencies resolved and not knowing why (see python-poetry/poetry#6819). PEP685 has been implemented in packaging since 9 months now (pypa/packaging#569), so it would just be an update to the vendored dependencies. Unfortunately, the corresponding feature request (#11650) has been closed as not being a bug even though it does solve a severe bug (this one), instead attention has been directed to an old, unrelated issue (#9250). However, the previous dependency update (#11502, which was 3 months after the packaging release) had missed to update packaging. In the meantime, we had a major release of pip, still not picking up this update. I'm worried that we will have to wait a full major release cycle to finally get this fixed.

@pradyunsg
Copy link
Member

pradyunsg commented Mar 17, 2023

If you wish to see the upgrade happen, please feel welcome to help with #11715.

I agree that this is problematic but it's not going to magically happen because it's problematic -- this project has limited contributor bandwidth and is primarily volunteer driven. For stuff like this to happen, someone needs to step up and do things. So far, none of the typical contributors have had the time to do so.

@AndydeCleyre
Copy link
Contributor

Does this issue track the following behavior, such that if this gets closed as resolved, the two numbers output will be the same?

$ pip --version
pip 24.0 from /... (python 3.12)
$ pip install --dry-run --quiet --report=- 'sentry_sdk[pure-eval]' | jq -r '.install[].metadata.name' | wc -l
3
$ pip install --dry-run --quiet --report=- 'sentry_sdk[pure_eval]' | jq -r '.install[].metadata.name' | wc -l
7

@chrysle
Copy link
Contributor

chrysle commented Mar 3, 2024

Does this issue track the following behavior, such that if this gets closed as resolved, the two numbers output will be the same?

I guess so, looking at #12431.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants