Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip 1.5rc3 is not generating script wrappers correctly #1403

Closed
pfmoore opened this issue Dec 29, 2013 · 11 comments
Closed

pip 1.5rc3 is not generating script wrappers correctly #1403

pfmoore opened this issue Dec 29, 2013 · 11 comments
Labels
auto-locked Outdated issues that have been locked by automation C: wheel The wheel format and 'pip wheel' command OS: windows Windows specific type: bug A confirmed bug or unintended behavior
Milestone

Comments

@pfmoore
Copy link
Member

pfmoore commented Dec 29, 2013

See the following:

PS 13:09 C:\Work\Scratch
>virtualenv --version
1.11rc3
PS 13:09 C:\Work\Scratch
>virtualenv test1
Using base prefix 'C:\\Apps\\Python33'
New python executable in test1\Scripts\python.exe
Installing setuptools, pip...done.
PS 13:09 C:\Work\Scratch
>test1\scripts\pip.exe --version
Fatal error in launcher: Failed to open script file "C:\Work\Scratch\test1\scripts\pip-script.py"
PS 13:09 C:\Work\Scratch

It looks like the exe script wrappers being generated are the old versions which use xxx-script.py.

@pfmoore
Copy link
Member Author

pfmoore commented Dec 29, 2013

@vsajip
Copy link
Contributor

vsajip commented Dec 30, 2013

I'm just about ready to cut a new distlib release, but as well as the update to the launcher binaries, there's an earlier update I did to add a local component to the PEP 440 version (as pre recent changes to that PEP). Can the pip team confirm that the current tip revision of distlib doesn't cause problems for pip in any area, so that I can make the release? I'm not sure whether pip uses distlib.version or related functionality (IIRC there may have been some use for pre-release checking).

@dstufft
Copy link
Member

dstufft commented Dec 30, 2013

I can give it a try, but it might be good for @pfmoore to do so, since he can test on Windows where this problem actually occurred?

@pfmoore
Copy link
Member Author

pfmoore commented Dec 30, 2013

What am I being asked to test? The script wrapper change worked when I tested it in distlib. It seems to me that Vinay is looking for verification that the other changes in this version of distlib don't cause problems.

Don't have much time right now, but I can try to build a release wheel and make sure it works. But the test is simply to take the rc virtualenv tarball, unpack it somwhere, do "python virtualenv.py foo" then "foo\Scripts\pip.exe" on Windows. It's building the release tarball (which I've never done) that'll take the time.

@vsajip
Copy link
Contributor

vsajip commented Dec 30, 2013

It seems to me that Vinay is looking for verification that the other changes in this version of distlib don't cause problems.

Confirmed.

@dstufft
Copy link
Member

dstufft commented Dec 31, 2013

My bad, I'll get this tested shortly.

@dstufft
Copy link
Member

dstufft commented Dec 31, 2013

Running the test suite here #1407

@dstufft
Copy link
Member

dstufft commented Dec 31, 2013

@vsajip Looks good to me.

@vsajip
Copy link
Contributor

vsajip commented Dec 31, 2013

distlib 0.1.6 has been released on PyPI.

@dstufft
Copy link
Member

dstufft commented Dec 31, 2013

Fixed Now!

@dstufft dstufft closed this as completed Dec 31, 2013
@pradyunsg pradyunsg removed !release blocker Hold a release until this is resolved labels Feb 8, 2019
@lock
Copy link

lock bot commented May 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: wheel The wheel format and 'pip wheel' command OS: windows Windows specific type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

No branches or pull requests

4 participants