Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinguish PEP440 filtering from pre-release filtering #1505

Closed
qwcode opened this issue Jan 26, 2014 · 5 comments
Closed

distinguish PEP440 filtering from pre-release filtering #1505

qwcode opened this issue Jan 26, 2014 · 5 comments
Labels
auto-locked Outdated issues that have been locked by automation
Milestone

Comments

@qwcode
Copy link
Contributor

qwcode commented Jan 26, 2014

for reference see #1492

the prerelease exclusion filter added in v1.4 also acts as a PEP440 filter (or at least a filter against anything that can't be normalized to PEP440 using distlib's "suggest" feature)

we need to backfill the 1.4 changelog (and update our docs) to make this clear.

going forward, we should make the PEP440 filter and the prerelease filter independent and distinguish the warnings for clarity. to do so, we'll add a new --allow-nonstandard-version (or --allow-legacy-version), to turn off the PEP440 filter.

This will mean a change in behavior for --pre. By itself, it won't turn on something like 1.3-fork1 anymore. that would require --allow-nonstandard-version.

@dstufft
Copy link
Member

dstufft commented Jan 26, 2014

+1

@techtonik
Copy link
Contributor

I'd also vote to provide opt-out ability to package authors from this intelligence that really gets in a way.

@techtonik
Copy link
Contributor

The package should have the ability to choose filtering method itself.

@dstufft
Copy link
Member

dstufft commented Dec 13, 2014

This is made invalid by bff1145.

@dstufft dstufft closed this as completed Dec 13, 2014
@qwcode
Copy link
Contributor Author

qwcode commented Dec 18, 2014

yay!

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

No branches or pull requests

3 participants