Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --build #4371

Closed
dstufft opened this issue Mar 24, 2017 · 4 comments
Closed

Deprecate --build #4371

dstufft opened this issue Mar 24, 2017 · 4 comments
Labels
state: needs discussion This needs some more discussion type: enhancement Improvements to functionality

Comments

@dstufft
Copy link
Member

dstufft commented Mar 24, 2017

We should deprecate and eventually remove --build. We tried this previously in #908 and ended up reverting it, however looking over our reasons for reverting it all those reasons seem better solved by the randomized build directories (which we weren't using at the time) or the TMPDIR environment variable.

@dstufft
Copy link
Member Author

dstufft commented Apr 2, 2017

In #4242 @benjaminp is using this flag to undo the move to a randomized build directory. This allows him to get reproducible build output even for packages that are generating files that bake in the build directory in some way (for example Numpy). He's using this instead of addressing the problem in each project that does that to provide a more systemic solution.

@jdemeyer
Copy link

jdemeyer commented Aug 22, 2017

In #4242 @benjaminp is using this flag to undo the move to a randomized build directory

This should still be possible. I am interested in the --build feature (which is broken, see #804 and #4242) for ccache to speed up compilations of C extensions.

@pradyunsg pradyunsg added state: needs discussion This needs some more discussion type: enhancement Improvements to functionality labels Oct 20, 2017
@toddrme2178
Copy link

We are having issues with this on openSUSE. The issue is that pyc files contain the build directory, at least for wheels, which is random each time. One option would be to support the -d option of compileall, which allows users to override the directory that is stored in the pyc file. This would allow us to specify the final destination directory rather than where it was built.

@pradyunsg
Copy link
Member

This has now been removed: #8372

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
state: needs discussion This needs some more discussion type: enhancement Improvements to functionality
Projects
None yet
Development

No branches or pull requests

4 participants