Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the upgrade-pip prompt look less like an error (to a new user) #5420

Closed
pradyunsg opened this issue May 17, 2018 · 5 comments
Closed

Make the upgrade-pip prompt look less like an error (to a new user) #5420

pradyunsg opened this issue May 17, 2018 · 5 comments
Labels
type: enhancement Improvements to functionality UX User experience related

Comments

@pradyunsg
Copy link
Member

pip's current upgrade prompt can be confusing for new users where they confuse the upgrade advice as advice for fixing errors they're facing.

One of the solutions for this would be to make the upgrade prompt look different from the error output so that a new user does not confuse it with the same.

Context: pypa/packaging-problems#149

@pradyunsg pradyunsg added this to the Improve User Experience milestone May 17, 2018
@pradyunsg pradyunsg added type: enhancement Improvements to functionality state: needs discussion This needs some more discussion labels May 17, 2018
@pradyunsg pradyunsg added the S: needs triage Issues/PRs that need to be triaged label May 17, 2018
@tkzv
Copy link

tkzv commented May 18, 2018

The nagging prompt causes users to break the system. There should be an option to disable the prompt.

@pfmoore
Copy link
Member

pfmoore commented May 18, 2018

There is. There's a --disable-pip-version-check option for pip, and system redistributors can patch out or modify the prompt.

@ncoghlan
Copy link
Member

ncoghlan commented May 20, 2018

Note that #5346 is a separate issue to silence this warning entirely when pip didn't get installed by pip. (see https://src.fedoraproject.org/rpms/python-pip/pull-request/5#request_diff for the downstream Fedora patch implementing that behaviour)

Upstream PR: https://github.com/pypa/pip/pull/5368/files

@pradyunsg
Copy link
Member Author

The point of this issue here is not that pip's upgrade prompt can cause users to break their systems (that's a whole other deal). That's #5346 as @ncoghlan pointed out.

The point here is that for someone who's getting started, when they have an outdated pip and have an error in the installation, the upgrade instructions seem like the solution to the error in installation.

Either the message needs be clearer in that case or at least somehow show that it's not related to the error.

@pradyunsg pradyunsg removed the S: needs triage Issues/PRs that need to be triaged label May 20, 2018
@nlhkabu nlhkabu added the UX User experience related label Jul 28, 2020
@nlhkabu nlhkabu removed this from the Improve User Experience milestone Jul 29, 2020
@ichard26
Copy link
Member

This can probably be closed with the merge of #10959 which changed the prompt to be much less scary. Stealing the screenshot, here's what it looks like now:
image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
@pradyunsg pradyunsg removed the state: needs discussion This needs some more discussion label Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Improvements to functionality UX User experience related
Projects
None yet
Development

No branches or pull requests

7 participants