Pip shouldn't use __main__.py in its warnings when invoked as a module

[webknjaz]

Environment

• pip version: 19.0.3
• Python version: 3.7.3
• OS: Fedora 30

Description

In its warning, Pip refers to mysterious __main__.py and I think that most of the entry-level users don't know what that is.
It would be more friendly to avoid using that name.

Expected behavior

WARNING: Running pip install with root privileges is generally not a good idea. Try `pip install --user` instead.

or (better)

WARNING: Running pip install with root privileges is generally not a good idea. Try `python3.7 -m pip install --user` instead.

How to Reproduce

sudo python -m pip install {{ pkg }}

Output

[root@4aab71e5d9d1 /]# python3.7 -m pip install epdb
WARNING: Running pip install with root privileges is generally not a good idea. Try `__main__.py install --user` instead.
...

[pradyunsg]

Hmm, I don't think that's vanilla pip.

@torsava @stratakis @hroncok Is this a patch applied by Fedora?

[hroncok]

Yes it is. https://src.fedoraproject.org/rpms/python-pip/blob/master/f/emit-a-warning-when-running-with-root-privileges.patch

[hroncok]

It's the sys.argv[0] value that isn't very good in this case. If you know how to get the actual command line invocation, that would be great. Of course, we could detect __main__ and replace it with sys.executable -m pip.

[hroncok]

@pradyunsg do you mind if we finish this conversation here?

[hroncok]

Like this?

        # Check whether we have root privileges and aren't in venv/virtualenv
        if os.getuid() == 0 and not is_venv():
            command = path.basename(sys.argv[0])
            if command == "__main__.py":
                command = path.basename(sys.executable) + " -m pip"
            logger.warning(
                "WARNING: Running pip install with root privileges is "
                "generally not a good idea. Try `%s install --user` instead."
                % command
            )

[webknjaz]

@hroncok getting the real (full) command line in Python is PITA and needs a lot of hacks.
Here's what I did a while back: https://github.com/cherrypy/cherrypy/blob/862a7d7/cherrypy/process/wspbus.py#L382-L511 (this could be extended by adding extra fallback looking at /proc/{{ PID }}/cmdline).

I've been meaning to release a dist with that to PyPI but never got to do it...

[webknjaz]

Also, you can think about something like this:

[pradyunsg]

@pradyunsg do you mind if we finish this conversation here?

Nope. :)

[pradyunsg]

@webknjaz Please do close this once this is resolved. :)

(or @ me since I'm unsubscribing for now)

[webknjaz]

I'm okay with closing it right away if @hroncok has a better place for tracking it. I just wanted to report it upstream but it doesn't actually affect me :)

[hroncok]

I'll do a PR in Fedora and post a link here. Unfortunately I won't get to it before Monday.

[hroncok]

https://src.fedoraproject.org/rpms/python-pip/pull-request/33

[webknjaz]

@hroncok should I keep this open?

[hroncok]

Whatever you prefer.

[webknjaz]

Okay, closing then.