New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #1192 #1218

Merged
merged 2 commits into from Oct 6, 2013

Conversation

Projects
None yet
1 participant
@qwcode
Contributor

qwcode commented Oct 2, 2013

fix for #1192

2 changes with tests:

  1. If the wheel name != search_name, then return immediately. Don't pass thru to the sdist matching code, which exposes wheel link matching unnecessarily to #1217.
  2. If somehow the pip code is broken, and unsupported wheels are being passed to the sorter, then at least fail with a meaningful error, not the TypeError which initiated #1192.

There's still a bug in sdist matching (#1217), but leaving that for 1.5, as fixing that involves more risk.

qwcode added some commits Oct 2, 2013

1) If the wheel name != search_name, then return immediately. Not doi…
…ng so,

exposes wheel link matching unnecessarily to Issue #1217.
2) If somehow the pip code is broken, and unsupported wheels are being
passed to the sorter, then atleast fail with a meaningful error.
@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Oct 3, 2013

Contributor

@alex, you mind confirming this branch works for you.
It's cut for 1.4.2. I'll merge over to develop afterwards.

Contributor

qwcode commented Oct 3, 2013

@alex, you mind confirming this branch works for you.
It's cut for 1.4.2. I'll merge over to develop afterwards.

qwcode added a commit that referenced this pull request Oct 6, 2013

@qwcode qwcode merged commit 3aafbab into pypa:1.4.X Oct 6, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment