Optionally load C dependencies based on platform

[mattlong]

PR for #4098.

I'm not thrilled importing from pip.compat to detect windows since it requires a del statement to leave no trace. Could of course duplicate the same logic to avoid the import + del, but that seems even worse.

[xavfernandez]

Changes to _vendor files should either be upstreamed to the vendored project (in this case requests) or use patches in https://github.com/pypa/pip/tree/master/tasks/vendoring.

[mattlong]

@xavfernandez The instructions for updating vendor patches seem incomplete. First, the pathlib package needs to be installed in addition to invoke. After that I'm still getting an error when running invoke vendoring.update as show below. Please advise.

[vendoring.update] Rewriting all imports related to vendored libs
Traceback (most recent call last):
  File "/Users/xxx/.virtualenvs/pip/bin/invoke", line 11, in <module>
    sys.exit(program.run())
  File "/Users/xxx/.virtualenvs/pip/lib/python2.7/site-packages/invoke/program.py", line 274, in run
    self.execute()
  File "/Users/xxx/.virtualenvs/pip/lib/python2.7/site-packages/invoke/program.py", line 389, in execute
    executor.execute(*self.tasks)
  File "/Users/xxx/.virtualenvs/pip/lib/python2.7/site-packages/invoke/executor.py", line 113, in execute
    result = call.task(*args, **call.kwargs)
  File "/Users/xxx/.virtualenvs/pip/lib/python2.7/site-packages/invoke/tasks.py", line 111, in __call__
    result = self.body(*args, **kwargs)
  File "/Users/xxx/projects/pip/tasks/vendoring/__init__.py", line 128, in main
    vendor(ctx, vendor_dir)
  File "/Users/xxx/projects/pip/tasks/vendoring/__init__.py", line 111, in vendor
    rewrite_file_imports(item, vendored_libs)
  File "/Users/xxx/projects/pip/tasks/vendoring/__init__.py", line 58, in rewrite_file_imports
    text = item.read_text()
AttributeError: 'PosixPath' object has no attribute 'read_text'

[mattlong]

@dstufft (or anyone else) What are your thoughts on this PR?

[xavfernandez]

@xavfernandez The instructions for updating vendor patches seem incomplete. First, the pathlib package needs to be installed in addition to invoke.

The vendoring.update task is expected to be run with python 3.5

[pradyunsg]

@xavfernandez Anything outstanding on this?

[xavfernandez]

This will need rebasing after #4342

[BrownTruck]

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

[alex]

Thing that just occurred to me: If pip starts supporting loading C-extensions again, we probably ought to make the openssl_version in the User-Agent reflect the version loaded by cryptography, not the one loaded by Python's ssl module.

[pradyunsg]

Removing from the 10.0 milestone since the linked issue is already in the milestone. :)

[amp343]

@mattlong I had opened a similar pr to this (#4612) without seeing yours first, but would be happy to consolidate around this one instead if you're still interested in working on it.

It looks like this one needs:

• a rebase
• a news entry in order to pass CI (a news/4098.bugfix file that describes the fix)

I would also recommend updating the readme here: https://github.com/pypa/pip/blame/master/pip/_vendor/README.rst#L100 to reflect this change to the treatment of c dependencies.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.