Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup testsuite - venv creation #4706

Merged
merged 4 commits into from
Sep 4, 2017

Conversation

benoit-pierre
Copy link
Member

Speedup virtualenv creation: create one (per session) relocatable virtual environment, and then just make a copy of the resulting tree when a new virtualenv is needed.

Running tox -e py36 -- -m integration -n4 on my machine:

  • takes 563.00 seconds on master
  • and 338.47 seconds with this PR (a ~40% speedup)

Note: #4663 is included to avoid future conflicts.

Speedup virtualenv creation: create one (per session) relocatable
virtual environment, and then just make a copy of the resulting tree
when a new virtualenv is needed.
@pradyunsg pradyunsg added type: maintenance Related to Development and Maintenance Processes C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) labels Sep 2, 2017
@pradyunsg
Copy link
Member

This is awesome! Thanks a lot for looking into this @benoit-pierre!

I knew there was a lot of low hanging fruit here. ^.^

@pradyunsg pradyunsg added the C: automation Automated checks, CI etc label Sep 2, 2017
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

@pradyunsg
Copy link
Member

Linking to #4497.

@pradyunsg
Copy link
Member

FTR; I don't think mixing #4663 is a good idea for review-bililty but I guess it's fine for once in a while.

@dstufft dstufft merged commit cd9ecdf into pypa:master Sep 4, 2017
@pradyunsg pradyunsg mentioned this pull request Sep 4, 2017
@benoit-pierre benoit-pierre deleted the speedup_testsuite branch September 4, 2017 11:28
@pradyunsg pradyunsg changed the title Speedup testsuite Speedup testsuite - venv creation Oct 5, 2017
@pradyunsg pradyunsg mentioned this pull request Oct 5, 2017
12 tasks
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants