support hash checks for url reqs with hash fragment #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the errors in this are caused by pypa/virtualenv#361 |
|
👍 |
|
/me hopes this gets merged soon. |
|
It might be useful to add a flag that enforces this check. This way pip versions that are too old to compute the hash would fail the install (unrecognised flag), and a hash fragment with a syntax typo or a missing hash would also fail the install. |
|
This looks like a nice enhancement. Maybe it can be revived? |
|
Sounds sort of like @erikrose's peep. Could be a nice addition to pip. |
|
Yep. It even satisfies #735 (comment). |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution for #468, with unit and functional tests.
this makes pip validate the hash if you did this:
pip install http://domain.com/pkg-1.2.tar.gz#md5=fce076628d299baa2f699ac3475a674cthe complicated part in this was the possibility of using #egg and hash fragments together. I've used #egg fragments in the past when using url tar requirements to give it a definite identity in the dependency resolution process to prevent this problem: #724