-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipenv shell fails to find /usr/local/bin/bash in pexpect #2496
Comments
Hmmm interesting. @uranusjr does this not follow symlinks currently? |
It shouldn’t need to. I use Hombrew Bash myself on Mac as well, and it works correctly. Given @keegancsmith Did |
I only occasionally do python development these days, so the last time I would of used |
It’s fine. We switched to a new shell implementation recently, and if it worked previously, it is probably related to the new implementation. I will try to debug it when I have access to my main Mac (which has the same Homebrew setup as yours). |
I'm encountering the same issue with zsh (5.5.1) on Arch Linux. So it's neither bash nor Mac specific. It was working just a few days ago.
It is still working on another machine with zsh + pipenv version 2018.6.25 |
@keegancsmith @Whisprin Can you run this with the Python you install Pipenv for me? (For Homebrew, this would be from pipenv.shells import _detect_emulator, detect_info
print(_detect_emulator())
print(detect_info()) And if Example (from my Mac):
|
I see it is detecting a stray
|
So it seems
note I use GNU screen, if that makes a difference. I can see in the vendored sourcecode if it finds a shell in a known list of shells, it doesn't strip |
Ah, I see the problem now. I was handling the shell path incorrectly if you |
Will there be a new release containing the bug fix? |
Is this not fixed yet in the latest on PyPI? Pretty egregious bug for a high-profile project:
|
Your problem seems to be different from the OP. She’ll detection works correctly, but |
Hi, it is in the path, but the code appears to be looking for an absolute path: ⏵ echo $SHELL |
Is |
Yes it is in |
Issue description
I can't run
pipenv shell
. This is different to the other issues related to this issue, since mySHELL
variable is correctly configured. It seems to be something pexpect is doing wrong.Expected result
Successfully running
pipenv shell
Actual result
Note:
/usr/local/bin/bash
is a symlink to/usr/local/Cellar/bash/4.4.23/bin/bash
(managed by brew). SettingSHELL
to that value or/bin/bash
both fail.Steps to replicate
Provide the steps to replicate (which usually at least includes the commands and the Pipfile).
$ pipenv --support
Pipenv version:
'2018.7.1'
Pipenv location:
'/usr/local/lib/python3.7/site-packages/pipenv'
Python location:
'/usr/local/opt/python/bin/python3.7'
Other Python installations in
PATH
:2.7
:/usr/local/bin/python2.7
2.7
:/usr/local/bin/python2.7
2.7
:/usr/bin/python2.7
3.7
:/usr/local/bin/python3.7m
3.7
:/usr/local/bin/python3.7
2.7.15
:/usr/local/bin/python
2.7.10
:/usr/bin/python
2.7.15
:/usr/local/bin/python2
3.7.0
:/usr/local/bin/python3
PEP 508 Information:
System environment variables:
STY
SRCPATH
MAILCHECK
LANG
XPC_FLAGS
HISTCONTROL
OLDPWD
TERM_SESSION_ID
EDITOR
COLORTERM
PERL_MB_OPT
__CF_USER_TEXT_ENCODING
LOCKPRG
ITERM_SESSION_ID
SSH_AUTH_SOCK
USER
GOPATH
PWD
HOME
WINDOW
TERM_PROGRAM
TERM_PROGRAM_VERSION
Apple_PubSub_Socket_Render
ITERM_PROFILE
PERL_MM_OPT
TMPDIR
PERL_LOCAL_LIB_ROOT
XPC_SERVICE_NAME
SHELL
TERM
PERL5LIB
COLORFGBG
SHLVL
LOGNAME
GOBIN
PATH
HISTSIZE
HISTFILESIZE
TERMCAP
_
PYTHONDONTWRITEBYTECODE
PIP_PYTHON_PATH
Pipenv–specific environment variables:
Debug–specific environment variables:
PATH
:/Users/keegan/.cargo/bin:/usr/local/opt/go/libexec/bin:/Users/keegan/bin:/Users/keegan/google-cloud-sdk/bin:/Users/keegan/.yarn/bin:/Users/keegan/perl5/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/keegan/.cargo/bin:/usr/local/opt/go/libexec/bin:/Users/keegan/bin:/Users/keegan/google-cloud-sdk/bin:/Users/keegan/.yarn/bin:/Users/keegan/perl5/bin:/Users/keegan/go/bin:/Users/keegan/go/bin
SHELL
:/usr/local/bin/bash
EDITOR
:vim
LANG
:en_GB.UTF-8
PWD
:/Users/keegan/go/src/github.com/weaveworks/kubediff
Contents of
Pipfile
('/Users/keegan/go/src/github.com/weaveworks/kubediff/Pipfile'):The text was updated successfully, but these errors were encountered: