-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fish completions don't tab complete file paths #3478
Comments
I also noticed this. Gonna talk to @kennethreitz about this since we're both fish shell users. I'm not sure if it's a config thing or shell setting. |
I have a similar problem, however i use bash instead of fish. When i run reproduce
softwarebash 4.4.20 |
For me, the most annoying part is, that e.g. |
Is this still an issue on latest pipenv? |
I did a short test with pipenv 2022.9.4 and the completion of executables for However, there is still no file completion for (By the way, the completion enablement file shipped with fish-shell itself appears to be outdated. I will update it there.) |
Please excuse me, the statement about So to come back to the question:
Yes, nothing has changed so far. But given that the completion logic switched from click-completion to the new built-in mechanism of click framework, which provides some new cool features, I think it is possible to improve pipenv's completions with this. Probably it requires writing some small utility functions that emit the correct completions or to augment the argument parsing definitions with the correct types. |
As expected, getting file/path completions for So the remaining part is getting completions for |
I'll just note that after being annoyed by this for quite a while, I tracked things down to this issue, which seems to apply equally to ZSH. I'm talking specifically about |
Issue description
When using fish shell, entering something like
pipenv run nvim
should allow tab-completion of file paths (this is just one example, obviously this would be the case for other commands run under pipenv too).Expected result
Tab completion works to complete filenames to edit. Ideally we should treat anything after
pipenv run
as another full fish command for completion (because it could be any valid command).Actual result
Nothing - tab completion just does nothing after entering
pipenv run nvim
.Steps to replicate
Try to tab complete file paths after
pipenv run <command>
, in my case it's neovim, sopipenv run nvim ./<tab>
just does nothing where it should complete the path.Please run
$ pipenv --support
, and paste the results here. Don't put backticks (`
) around it!$ pipenv --support
Pipenv version:
'2018.11.26'
Pipenv location:
'/usr/local/Cellar/pipenv/2018.11.26/libexec/lib/python3.7/site-packages/pipenv'
Python location:
'/usr/local/Cellar/pipenv/2018.11.26/libexec/bin/python3.7'
Python installations found:
3.8.0a0
:/Users/jbramley/.pyenv/versions/3.8-dev/bin/python3
3.8.0a0
:/Users/jbramley/.pyenv/versions/3.8-dev/bin/python3.8m
3.7.2
:/usr/local/bin/python3
3.7.2
:/usr/local/bin/python3.7m
3.7.1
:/Users/jbramley/.pyenv/versions/shopping_cart_3.7/bin/python3
3.7.1
:/Users/jbramley/.pyenv/versions/3.7.1/bin/python3.7m
3.7.0
:/Users/jbramley/.pyenv/versions/3.7.0/bin/python3
3.7.0
:/Users/jbramley/.pyenv/versions/3.7.0/bin/python3.7m
3.6.5
:/Users/jbramley/.pyenv/versions/TMP2/bin/python3
3.6.5
:/Users/jbramley/.pyenv/versions/3.6.5/bin/python3.6m
2.7.15
:/usr/local/bin/python
2.7.15
:/usr/local/bin/pythonw
2.7.14
:/Users/jbramley/.pyenv/versions/neovim2/bin/python
2.7.14
:/Users/jbramley/.pyenv/versions/2.7.14/bin/python
2.7.10
:/usr/bin/python
2.7.10
:/usr/bin/pythonw
2.7.10
:/usr/bin/python2.7
PEP 508 Information:
System environment variables:
PATH
TERM_PROGRAM
PYENV_ROOT
TERM
SHELL
TMPDIR
Apple_PubSub_Socket_Render
TERM_PROGRAM_VERSION
TERM_SESSION_ID
INGESTER_LOGLEVEL
USER
PIPENV_MAX_DEPTH
theme_color_scheme
COMMAND_MODE
SSH_AUTH_SOCK
__CF_USER_TEXT_ENCODING
PYENV_VIRTUALENV_INIT
fish_user_paths
PWD
EDITOR
LANG
ITERM_PROFILE
XPC_FLAGS
XPC_SERVICE_NAME
SHLVL
PYENV_SHELL
HOME
COLORFGBG
ITERM_SESSION_ID
LOGNAME
INDEXER_LOGLEVEL
GOPATH
INGESTER_EVENTSTORE_DISCOVERY_HOST
SECURITYSESSIONID
COLORTERM
PIP_DISABLE_PIP_VERSION_CHECK
PYTHONDONTWRITEBYTECODE
PIP_SHIMS_BASE_MODULE
PIP_PYTHON_PATH
PYTHONFINDER_IGNORE_UNSUPPORTED
Pipenv–specific environment variables:
PIPENV_MAX_DEPTH
:8
Debug–specific environment variables:
PATH
:/usr/local/Cellar/pipenv/2018.11.26/libexec/tools:/usr/local/Cellar/pyenv-virtualenv/1.1.3/shims:/Users/jbramley/.pyenv/shims:/Users/jbramley/.pyenv/shims:/Users/jbramley/Scripts/:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
SHELL
:/usr/local/bin/fish
EDITOR
:nvim
LANG
:en_GB.UTF-8
PWD
:/Users/jbramley/Code/madedotcom/eg2
Contents of
Pipfile
('/Users/jbramley/Code/madedotcom/eg2/Pipfile'):Contents of
Pipfile.lock
('/Users/jbramley/Code/madedotcom/eg2/Pipfile.lock'):The text was updated successfully, but these errors were encountered: