-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipenv requirements / pipenv lock --requirements loses "name@" prefix #5432
Comments
no change, still written as also, some unwanted formatting changes have appeared: diff --git a/requirements.txt b/requirements.txt
index 42a5389a..6b36075b 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,38 +1,33 @@
-#
-# These requirements were autogenerated by pipenv
-# To regenerate from the project's Pipfile, run:
-#
-# pipenv lock --requirements
-#
-
--i https://pypi.org/simple/
+-i https://pypi.org/simple
appdirs==1.4.4
-attrs==22.1.0; python_version >= '3.5'
-cattrs==22.2.0; python_version >= '3.7'
+attrs==22.1.0 ; python_version >= '3.5'
+cattrs==22.2.0 ; python_version >= '3.7'
certifi==2022.9.24
-charset-normalizer==2.1.1; python_version >= '3.6'
+charset-normalizer==2.1.1 ; python_version >= '3.6'
click==8.1.3
commonmark==0.9.1
deprecated==1.2.13
-idna==3.4; python_version >= '3.5'
+exceptiongroup==1.0.4 ; python_version < '3.11'
+idna==3.4 ; python_version >= '3.5'
inquirerpy==0.3.4
oauthlib==3.2.2
-pfzy==0.3.4; python_version >= '3.7' and python_version < '4.0'
+pfzy==0.3.4 ; python_version >= '3.7' and python_version < '4.0'
plexapi==4.13.1
-prompt-toolkit==3.0.33; python_full_version >= '3.6.2'
-pygments==2.13.0; python_version >= '3.6'
+prompt-toolkit==3.0.33 ; python_full_version >= '3.6.2'
+pygments==2.13.0 ; python_version >= '3.6'
python-dotenv==0.21.0
python-git-info==0.8.2
pytrakt==3.4.13
pyyaml==6.0
-requests-cache==0.9.6
-requests-oauthlib==1.3.1; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'
requests==2.28.1
+requests-cache==0.9.6
+requests-oauthlib==1.3.1 ; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'
rich==12.6.0
-six==1.16.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'
+six==1.16.0 ; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'
tqdm==4.64.1
-url-normalize==1.4.3; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4, 3.5'
+https://github.com/glensc/python-trakt/archive/refs/tags/3.4.1.zip
+url-normalize==1.4.3 ; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4, 3.5'
urllib3==1.26.12
wcwidth==0.2.5
websocket-client==1.4.2
-wrapt==1.14.1; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4'
+wrapt==1.14.1 ; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4' |
@glensc I just tried this and while its written the way you describe (without the name@ prefix) I actually don't run into any issues installing it in the main branch (ignore the deprecation warnings, we are fixing that):
|
Also:
|
and |
This is what pipenv 2022.9.24 requirements produces: |
Ah ok I didn't check |
@glensc A lot has changed internal to pipenv (acknowledging that I broke a couple things in a major refactor that was released this past week but much of that has been fixed and I expect editable file dependencies to be patched this weekend); that being said, I am curious of this is still an issue with the latest versions -- if still an issue, we can now prioritize fixing it without the burdens of requirementslib making it hard to do. |
with 2023.11.17. tested with these commands:
Pipfile looks like this: diff --git a/Pipfile b/Pipfile
index 51701561..2086f619 100644
--- a/Pipfile
+++ b/Pipfile
@@ -38,6 +38,7 @@ urllib3 = "==2.1.0"
wcwidth = "==0.2.13"
websocket-client = "==1.7.0"
wrapt = {version="==1.16.0", python_version=">='3.5'"}
+trakt = {file = "https://github.com/glensc/python-trakt/archive/refs/tags/3.4.1.zip"}
[requires]
python_version = "3" but the original bug report of requirements.txt is not: diff --git a/requirements.txt b/requirements.txt
index d8b35416..4b6668c7 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -5,6 +5,7 @@ certifi==2023.11.17; python_version >= '3.6'
charset-normalizer==3.3.2; python_full_version >= '3.7.0'
click==8.1.7; python_version >= '3.7'
deprecated==1.2.14; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'
+exceptiongroup==1.2.0; python_version < '3.11'
idna==3.6; python_version >= '3.5'
inquirerpy==0.3.4; python_version >= '3.7' and python_version < '4.0'
markdown-it-py==3.0.0; python_version >= '3.7' and python_version >= '3.8'
@@ -26,6 +27,8 @@ requests-oauthlib==1.3.1; python_version >= '2.7' and python_version not in '3.0
rich==13.7.0; python_full_version >= '3.7.0'
six==1.16.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3' and python_version >= '3.4'
tqdm==4.66.1; python_version >= '3.7'
+https://github.com/glensc/python-trakt/archive/refs/tags/3.4.1.zip
+typing-extensions==4.9.0; python_version < '3.11'
url-normalize==1.4.3; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4, 3.5' and python_version >= '3.6'
urllib3==2.1.0; python_version >= '3.8'
wcwidth==0.2.13 so, should be re-opened as not fixed |
...so, should be re-opened as not fixed |
This comment was marked as outdated.
This comment was marked as outdated.
I've tested with:
this results: diff --git a/Pipfile b/Pipfile
index 51701561..0e21062a 100644
--- a/Pipfile
+++ b/Pipfile
-pytrakt = "==3.4.26"
+pytrakt = {ref = "refs/pull/37/head", git = "git+https://github.com/glensc/python-pytrakt"}
diff --git a/requirements.txt b/requirements.txt
index d8b35416..04a9dad0 100644
--- a/requirements.txt
+++ b/requirements.txt
-pytrakt==3.4.26
+pytrakt@ git+https://github.com/glensc/python-pytrakt@c8b1415ab8eb16156a49c48d90b57da3585b80bc requirements.txt is installable with pip and also:
this results: diff --git a/Pipfile b/Pipfile
index 51701561..a00755fa 100644
--- a/Pipfile
+++ b/Pipfile
-pytrakt = "==3.4.26"
+pytrakt = {file = "https://github.com/glensc/python-trakt/archive/refs/tags/3.4.27.zip"}
--- a/requirements.txt
+++ b/requirements.txt
-pytrakt==3.4.26
+https://github.com/glensc/python-trakt/archive/refs/tags/3.4.27.zip requirements.txt is installable with pip I don't recall why I used the "@" syntax in first place because this also works and lastly
diff --git a/Pipfile b/Pipfile
index 51701561..a00755fa 100644
--- a/Pipfile
+++ b/Pipfile
-pytrakt = "==3.4.26"
+pytrakt = {file = "https://github.com/glensc/python-trakt/archive/refs/tags/3.4.27.zip"}
diff --git a/requirements.txt b/requirements.txt
index d8b35416..605e2a59 100644
--- a/requirements.txt
+++ b/requirements.txt
-pytrakt==3.4.26
+https://github.com/glensc/python-trakt/archive/refs/tags/3.4.27.zip oh wait, the
diff --git a/Pipfile b/Pipfile
index 51701561..a00755fa 100644
--- a/Pipfile
+++ b/Pipfile
-pytrakt = "==3.4.26"
+pytrakt = {file = "https://github.com/glensc/python-trakt/archive/refs/tags/3.4.27.zip"}
diff --git a/requirements.txt b/requirements.txt
index d8b35416..7b472d26 100644
--- a/requirements.txt
+++ b/requirements.txt
-pytrakt==3.4.26
+https://github.com/glensc/python-trakt/archive/refs/tags/3.4.27.zip |
@matteius I've done some tests and shared their outcome, they doesn't behave identically, but it also produces EDIT: the "name@" syntax I used initially because it was in setuptools documentation: |
Issue description
I'm adding dependency using "Direct URL dependencies":
this results in an entry to
Pipfile
:and
Pipfile.lock
:so far so good.
now to sync requirements.txt the line needs to be:
but sync command puts only URL there:
(optional) for extra information, why the requirements line must be like that, you can read in this thread:
(optional) and why installing this way:
Expected result
requirements.txt
line must retain "name@" for pip to install from it.Actual result
requirements.txt
file with just URL will result pip parse error, which means it must be manually edited before publishing the changeSteps to replicate
The steps are listed in description block.
If needed the repository with the test can be browsed at:
$ pipenv --support
Pipenv version:
'2022.9.24'
Pipenv location:
'/usr/local/Cellar/pipenv/2022.9.24/libexec/lib/python3.10/site-packages/pipenv'
Python location:
'/usr/local/Cellar/pipenv/2022.9.24/libexec/bin/python3.10'
OS Name:
'posix'
User pip version:
'22.2.2'
user Python installations found:
3.10.8
:/Users/glen/MegaSync/scm/plex/PlexTraktSync/.direnv/python-3.10.8/bin/python3
3.10.8
:/Users/glen/MegaSync/scm/plex/PlexTraktSync/.direnv/python-3.10.8/bin/python
3.10.8
:/Users/glen/MegaSync/scm/plex/PlexTraktSync/.direnv/python-3.10.8/bin/python3
3.10.8
:/Users/glen/MegaSync/scm/plex/PlexTraktSync/.direnv/python-3.10.8/bin/python
3.10.8
:/usr/local/opt/python@3.10/bin/python3
3.10.8
:/usr/local/bin/python3
3.9.15
:/usr/local/bin/python3.9
3.8.15
:/usr/local/bin/python3.8
3.8.2
:/usr/bin/python3
2.7.17
:/usr/local/opt/python@2/bin/python
2.7.17
:/usr/local/opt/python@2/bin/python2
2.7.17
:/usr/local/opt/python@2/bin/python2.7
2.7.17
:/usr/local/bin/python
2.7.17
:/usr/local/bin/python2
2.7.17
:/usr/local/bin/python2.7
2.7.16
:/usr/bin/python
2.7.16
:/usr/bin/python2
2.7.16
:/usr/bin/python2.7
PEP 508 Information:
System environment variables:
PATH
GREP_COLOR
STARSHIP_SHELL
MANPATH
TERM_PROGRAM
HOSTNAME
GEM_HOME
HOST
TERM
PIPENV_VERBOSITY
SHELL
HISTSIZE
TMPDIR
PERL5LIB
DIRENV_DIR
TERM_PROGRAM_VERSION
GIT_HOSTING
HOMEBREW_AUTO_UPDATE_SECS
PLEX_PASSWORD
PERL_MB_OPT
TERM_SESSION_ID
GITHUB_API_TOKEN
PLEX_BASEURL
HISTFILESIZE
USER
MPD_HOST
TITLE
COMMAND_MODE
RBENV_ROOT
BASH_IT_THEME
SCM_CHECK
VERSION_CONTROL
SSH_AUTH_SOCK
__CF_USER_TEXT_ENCODING
AUTOFEATURE
VIRTUAL_ENV
SCREENDIR
DIRENV_WATCHES
BASH_IT
TRAKT_API_KEY
LSCOLORS
DBPOOL_INIDIR
COMPOSE_DOCKER_CLI_BUILD
SYSSCREENRC
_
LaunchInstanceID
TTY
PWD
HOMEBREW_GITHUB_API_TOKEN
FZF_ALT_C_COMMAND
EDITOR
LANG
ITERM_PROFILE
PYPI_TOKEN
XPC_FLAGS
PASSWORD_STORE_DIR
PLEX_USERNAME
XPC_SERVICE_NAME
DOCKER_BUILDKIT
DIRENV_FILE
HISTCONTROL
TRAKT_AUTHORIZATION
SHLVL
COLORFGBG
HOME
TQDM_TELEGRAM_CHAT_ID
DEV_ENV
LESS_ADVANCED_PREPROCESSOR
LC_TERMINAL_VERSION
HOMEBREW_PREFIX
PERL_LOCAL_LIB_ROOT
ITERM_SESSION_ID
STARSHIP_SESSION_KEY
LOGNAME
VISUAL
LC_CTYPE
GEM_PATH
LESSOPEN
BYOBU_PREFIX
TODO
DISPLAY
IRC_CLIENT
LC_TERMINAL
TQDM_TELEGRAM_TOKEN
DIRENV_DIFF
LC_TIME
SECURITYSESSIONID
PERL_MM_OPT
COLORTERM
PIP_DISABLE_PIP_VERSION_CHECK
PIP_PYTHON_PATH
PYTHONDONTWRITEBYTECODE
PLEX_TOKEN
PLEX_SERVER
PLEX_FALLBACKURL
TRAKT_USERNAME
PYTHONFINDER_IGNORE_UNSUPPORTED
Pipenv–specific environment variables:
PIPENV_VERBOSITY
:-1
Debug–specific environment variables:
PATH
:/usr/local/Cellar/pipenv/2022.9.24/libexec/tools:/Users/glen/MegaSync/scm/plex/PlexTraktSync/.direnv/python-3.10.8/bin:/Users/glen/MegaSync/scm/plex/PlexTraktSync/.direnv/python-3.10.8/bin:/Users/glen/perl5/bin:/usr/local/opt/openjdk/bin:/usr/local/opt/make/libexec/gnubin:/usr/local/opt/python@2/bin:/usr/local/opt/python@3.10/bin:/usr/local/opt/gnu-tar/libexec/gnubin:/usr/local/opt/gnu-sed/libexec/gnubin:/usr/local/opt/gnu-getopt/bin:/usr/local/opt/gettext/bin:/usr/local/opt/findutils/libexec/gnubin:/usr/local/opt/coreutils/libexec/gnubin:/usr/local/opt/gems/bin:/Users/glen/go/bin:/Users/glen/.local/bin:/usr/local/sbin:/Users/glen/.composer/vendor/bin:/Users/glen/.local/npm/bin:/Users/glen/Dropbox/bin:/Users/glen/Dropbox/Linux/config/bin:/Users/glen/.composer/vendor/bin:/Users/glen/.local/bin/phars/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/games:/Users/glen/scm/glen/okas/bin:/usr/local/opt/fzf/bin:/Users/glen/.krew/bin
SHELL
:/usr/local/bin/bash
EDITOR
:/usr/local/bin/nvim
LANG
:en_US.UTF-8
PWD
:/Users/glen/scm/plex/PlexTraktSync
VIRTUAL_ENV
:/Users/glen/MegaSync/scm/plex/PlexTraktSync/.direnv/python-3.10.8
Contents of
Pipfile
('/Users/glen/MegaSync/scm/plex/PlexTraktSync/Pipfile'):Contents of
Pipfile.lock
('/Users/glen/MegaSync/scm/plex/PlexTraktSync/Pipfile.lock'):The text was updated successfully, but these errors were encountered: