Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command descriptions in doc #1820

Closed
wants to merge 2 commits into from
Closed

Conversation

frostming
Copy link
Contributor

@frostming frostming commented Mar 22, 2018

Update sphinx-click to the master branch

Closes #1819

Preview
image

@uranusjr
Copy link
Member

This is cool, but why can’t we wait until it’s pushed to PyPI?

@frostming
Copy link
Contributor Author

Because I think the command docs will help new comers get into pipenv more quickly, but the release schedule can't be predicted.

But if you insist on not adding git editables to dev-package, I will update the Pipfile as soon as it is released.

@uranusjr
Copy link
Member

I’m more in favour of following stable releases.

@stephenfin
Copy link

I’m more in favour of following stable releases.

I've gone ahead and released 1.1.0. You can use this now.

@frostming
Copy link
Contributor Author

@stephenfin, thanks for that

allow_prereleases = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed after upgrading to sphinx-click 1.1.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uranusjr not related to this PR but is black still in prerelease? If so then this line is necessary if you want to install white & have black work properly

@techalchemy techalchemy added the Type: Documentation 📖 This issue relates to documentation of pipenv. label Mar 22, 2018
@frostming
Copy link
Contributor Author

because this pr only updates Pipfile.lock, I'd like to close it to keep the commit log clean.

@frostming frostming closed this Mar 23, 2018
@frostming frostming mentioned this pull request Mar 26, 2018
@frostming frostming deleted the cli-docs branch March 26, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation 📖 This issue relates to documentation of pipenv.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants