Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check lockfile exists on sync, and don't update it #2131

Merged
merged 1 commit into from
May 4, 2018
Merged

Check lockfile exists on sync, and don't update it #2131

merged 1 commit into from
May 4, 2018

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented May 3, 2018

Matching the behaviour mentioned in #1463 (comment)

@uranusjr uranusjr force-pushed the sync-shouldnt-lock branch 2 times, most recently from 23257d3 to d7d2f81 Compare May 3, 2018 15:24
@erinxocon
Copy link
Contributor

Thanks for the fix @uranusjr! If all tests go well I think this can be merged.

@techalchemy techalchemy self-assigned this May 3, 2018
@techalchemy techalchemy added the Type: Regression This issue is a regression of a previous behavior. label May 3, 2018
@techalchemy techalchemy added this to the 11.10.2 milestone May 3, 2018
@techalchemy techalchemy merged commit 962ce7b into master May 4, 2018
@techalchemy techalchemy deleted the sync-shouldnt-lock branch May 4, 2018 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Regression This issue is a regression of a previous behavior.
Projects
None yet
Milestone
11.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@uranusjr @erinxocon @techalchemy