Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show better error if virtual env is broken #2595

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

sinscary
Copy link
Contributor

@sinscary sinscary commented Jul 17, 2018

This shows the better error to the user if virtual env is broken
also suggests commands that can solve the issue

Closes #1918

@uranusjr
Copy link
Member

Hi, thanks for the work! I feel the pipenv install part could be made more general—people don’t necessarily use it to bootstrap their environments, and generally want to specify a Python version/executable themselves. Something like “Running pipenv --rm and rebuild the virtual environment may resolve the issue” could be better, but I wonder if that is a clear enough instruction for more relatively inexperienced users. What do you think?

@sinscary
Copy link
Contributor Author

sinscary commented Jul 17, 2018

@uranusjr You are right. I think we can show this error message something like this,
"Running pipenv --rm and rebuild the virtual environment with pipenv install <python_version> may resolve the issue", What say?

@uranusjr
Copy link
Member

Maybe something like “… rebuild the virtual environment, e.g. pipenv install”?

@sinscary
Copy link
Contributor Author

sinscary commented Jul 17, 2018

Yeah, that's also good. But I think that if it comes to specifying the python version, it still might be confusing for them. Then I think we shouldn't even specify the pipenv install command. I think what you suggested first would be much better.

@uranusjr
Copy link
Member

I’m very bad at figuring out what is more understandable for newcomers, so I’ll leave the decision to you :) I’ll merge either way.

@sinscary
Copy link
Contributor Author

Well, I think the first one you suggested was good so I am going with it.

@uranusjr uranusjr merged commit bb5201e into pypa:master Jul 18, 2018
slhck added a commit to slhck/pipenv that referenced this pull request Jul 18, 2018
slhck added a commit to slhck/pipenv that referenced this pull request Jul 18, 2018
Copy link

@Raffffqq Raffffqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [ ]

Copy link

@Raffffqq Raffffqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • IMG-20240119-WA0001.jpeg

  • @__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants