Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #3191, #3196 and #3209 #3217

Merged
merged 89 commits into from Nov 14, 2018
Merged

Merge #3191, #3196 and #3209 #3217

merged 89 commits into from Nov 14, 2018

Conversation

@techalchemy
Copy link
Member

@techalchemy techalchemy commented Nov 13, 2018

Let's make sure these merge cleanly

devxpy and others added 30 commits Oct 27, 2018
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
- Implement improvements and bugfixes in codebase
- Remote archives will now resolve properly

Signed-off-by: Dan Ryan <dan@danryan.co>
- Specific construct for isolationg operations

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy added 6 commits Nov 13, 2018
- Fixes #3216

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@frostming
Copy link
Contributor

@frostming frostming commented Nov 14, 2018

Good job Dan, we are getting close now 🎉

>       split_dict = pipenv.utils.split_file(pipfile_dict)
E       AttributeError: 'module' object has no attribute 'split_file'
frostming and others added 9 commits Nov 14, 2018
- Closes #2200

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
…191-3196-3209

- Closes #2200
- Closes #3112 (via merge)

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Copy link
Member Author

@techalchemy techalchemy commented Nov 14, 2018

Literally no idea why the new thing is failing....

@techalchemy
Copy link
Member Author

@techalchemy techalchemy commented Nov 14, 2018

Hmm maybe I left those in version control on the other packages. Otherwise everything passed so I’m cutting a release in a few mins

techalchemy added 4 commits Nov 14, 2018
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy merged commit d9ebad3 into master Nov 14, 2018
2 checks passed
2 checks passed
pipenv CI (Linux) #Pipenv Build Rules succeeded
Details
pipenv CI (Windows) #Pipenv Build Rules succeeded
Details
@techalchemy techalchemy deleted the maintenance/merge-3191-3196-3209 branch Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants