Fix --site-packages flag is not recognized

[nonylene]

The issue

#3351

site_packages argument in cli function always set to false because --site-packages flag was defined in the global state (

pipenv/pipenv/cli/options.py

Line 62 in 97657b2

self.site_packages = False

).

The fix

Remove site_packages argument form cli function and make use state.site_packages.

The checklist

• Associated issue
• A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

[jxltom]

Thanks for this. It is because expose_value=False is used for --site-packages option as in

pipenv/pipenv/cli/options.py

Lines 265 to 267 in 8707fe5

	return option("--system", is_flag=True, default=False, help="System pip management.",
	callback=callback, type=click.types.BOOL, expose_value=False,
	show_envvar=True)(f)

.

We should also check options with expose_value=False but used in

pipenv/pipenv/cli/command.py

Lines 62 to 81 in 8707fe5

	def cli(
	ctx,
	state,
	where=False,
	venv=False,
	rm=False,
	bare=False,
	three=False,
	python=False,
	help=False,
	py=False,
	site_packages=False,
	envs=False,
	man=False,
	completion=False,
	pypi_mirror=None,
	support=None,
	clear=False,
	**kwargs
	):

.

BTW, it will be nice if you also include tests for this. Thanks!

[jxltom]

I checked that --clear has same issue, and made PR #3354 for that.

[techalchemy]

To be honest we just need a thing that tests every CLI flag and makes sure it makes it through to the corresponding function

[jxltom]

Yes, it will be nice to test the behavior as well. :D

[nonylene]

Test added in f81e861.

[techalchemy]

awesome, thank you so much for handling this! 🍰

[nonylene]

Thanks!