Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyenv as it is broken on new pythonfinder version. #5686

Merged
merged 6 commits into from
May 17, 2023

Conversation

matteius
Copy link
Member

@matteius matteius commented May 14, 2023

Vendor in pythonfinder==2.0.1

Backstory:

I discovered that pyenv was broken with the new pythonfinder. It was trying to install the system python and alerting that it was different than what was called out in the Pipfile. Despite pyenv being installed, it did nothing to try and use those versions.

This also cleans up some other edge cases around pyenv:

  • Ensures the shims directories will not be included (there was logic for this in there, but the paths weren't matching)
  • Ensures the version directories are included on the PATH

@matteius matteius requested a review from oz123 May 17, 2023 02:13
@oz123 oz123 merged commit a101d1e into main May 17, 2023
@oz123 oz123 deleted the pythonfinder-fix-pyenv branch May 17, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants