Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on packaging to parse the version. #343

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Rely on packaging to parse the version. #343

merged 3 commits into from
Jan 29, 2020

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jan 26, 2020

Fixes #339.

@layday
Copy link
Member

layday commented Jan 26, 2020 •
edited
Loading

This should also probably be using the release and pre attributes on Version instead of a private attribute.

@jaraco
Copy link
Member Author

jaraco commented Jan 26, 2020

use Version public attributes

Yes, I agree, but I sought to make this change minimally invasive. I'm happy to accept a more invasive change.

@uranusjr
Copy link
Member

@jaraco Would it be a good idea to file a follow up PR to refactor out the private attribute. I’m willing to merge this if that’s the case.

@jaraco
Copy link
Member Author

jaraco commented Jan 29, 2020

Yes, it would be a good idea.

@gaborbernat gaborbernat merged commit 2bb384a into pypa:master Jan 29, 2020
@jaraco jaraco deleted the bugfix/implicit-setuptools branch January 29, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

>= 0.15 has undeclared dependency on setuptools
4 participants
@jaraco @layday @uranusjr @gaborbernat