Recommend using twine check instead
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
approved these changes
Sep 21, 2018
di
commented
Sep 21, 2018
README.rst
Outdated
| @@ -44,4 +22,7 @@ Code of Conduct | |||
| Everyone interacting in the readme_renderer project's codebases, issue trackers, | |||
| chat rooms, and mailing lists is expected to follow the `PyPA Code of Conduct`_. | |||
|
|
|||
|
|
|||
| .. |twine check| replace:: ``twine check`` | |||
| .. _twine check: https://github.com/pypa/twine#twine-check | |||
There was a problem hiding this comment.
Hmm, perhaps it would be better to link to the new section that pypa/packaging.python.org#554 is adding instead. I'll update this after that's merged.
di
force-pushed
the
deprecate-setuppy-check
branch
from
7f4e1d7
to
35c0885
Compare
webknjaz
added a commit
to cherrypy/cheroot
that referenced
this pull request
Oct 5, 2018
|
Why exactly is this deprecated? |
|
Probably because not everyone is using setup.py, so it’s becoming less central to the workflow (somewhat like how tox replaced setup.py test). |
miketheman
added a commit
to miketheman/readme_renderer
that referenced
this pull request
Mar 23, 2022
The `check` command was ported to `twine check` in 2018. Refs: pypa#122 Python 3.10 and 3.11 have marked `distutils` as deprecated. Refs: https://peps.python.org/pep-0632/#specification Signed-off-by: Mike Fiedler <miketheman@gmail.com>
di
pushed a commit
that referenced
this pull request
Mar 23, 2022
The `check` command was ported to `twine check` in 2018. Refs: #122 Python 3.10 and 3.11 have marked `distutils` as deprecated. Refs: https://peps.python.org/pep-0632/#specification Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the README for this repo to recommend using the new
twine checkcommand instead ofsetup.py check -r -s.It also adds a deprecation notice for the old command.
This should be merged once the new version of Twine is released.