Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with distutils at e0787fa #3674

Merged
merged 33 commits into from
Nov 18, 2022
Merged

Sync with distutils at e0787fa #3674

merged 33 commits into from
Nov 18, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Nov 13, 2022

  • Remove docstring in distutils
  • Prefer partition for splitting a string.
  • Remove readme
  • Prefer relative imports for better portability.
  • No need to save 'threshold' on the instance.
  • Use monkeypatch to set log and threshold.
  • Extract fixture for capturing logs in _util modules.
  • Expand 'logs' fixture to support features needed by LoggingSilencer.
  • Consolidate fixture for capturing logs. Removes LoggingSilencer.
  • Prefer capsys to test.support.captured*
  • Fix broken test
  • Prefer caplog to mocking the logging interface.
  • or maybe not
  • Remove setting of dll_libraries in Mingw32CCompiler. One call superseded the other, and the result was redundant with what happens in the parent call.
  • Short circuit when MSC version is not found.
  • Prefer partition to find.
  • Work with ints uniformally.
  • Replace if/else with a lookup.
  • Move lookup out of the function
  • Prefer regex search to string manipulation.
  • Use RangeMap to define the ranges in one place.
  • Use try/except when assigning msc_ver.
  • 👹 Feed the hobgoblins (delint).
  • Re-paste RangeMap with newlines restored (unsure what made them disappear).
  • Pin pytest to <7.2. Workaround for test_bdist_ext tests started failing with pytest 7.2 distutils#186.
  • In TempdirManager, use pathlib and more_itertools to more simply write the text.
  • Rewrite init/for/append loop as comprehension and if/else as tertiary statement.
  • Replace bespoke logging facility with logging module, available since Python 2.3.
  • Avoid use of the distutils.log module.
  • Log to the root logger, as that's the one Setuptools patches/validates.

Summary of changes

Closes

Pull Request Checklist

…ded the other, and the result was redundant with what happens in the parent call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant