Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add Framework :: napari trove classifier #53

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

jni
Copy link
Contributor

@jni jni commented Oct 18, 2020

Request to add a new Trove classifier.

The name of the classifier(s) you would like to add:

  • Framework :: napari

Why do you want to add this classifier?

napari is a multidimensional image viewer for Python. It has a plugin framework, based on pytest's pluggy, that currently allows independently libraries to add new IO capabilities to napari. An IO plugin allows users to drag and drop a previously unsupported image file format into the viewer, or to save the current view to a new format.

We would like the trove classifier to be able to discover plugins on PyPI and allow users to install them from napari directly. The (pip-based) installation infrastructure already exists in napari, but currently the user must manually specify the name of the PyPI package they would like to install — they have no way to list all available plugins.

Here is a partial list of existing plugins on PyPI:

Everyone tagged above (:wave:): if you could submit a comment of support in this issue, or at least thumbs-up this comment (or both!), it would help us help users discover your plugins! :blush: See this comment by @pradyunsg (:wave:) for details.

In addition to the list above, we are soon going to expand the number of hook specifications we make available to developers (not just IO, but image processing hooks), so we expect the above list to continue growing. @quantumjot, @haesleinhuepf, and @guiwitz are among those who could probably attest to wanting to write napari processing plugins.

@alisterburt
Copy link

this would be fantastic! very much looking forward to the extra hook specifications too

@adamltyson
Copy link

Very happy to support this. I have two plugins so far, and discoverability will be key for the upcoming image processing plguins.

@manzt
Copy link

manzt commented Oct 18, 2020

+1 - great idea to increase visibility / discoverability of plugins

@will-moore
Copy link

This would be great, thanks! 👍

@DragaDoncila
Copy link

This would be great - especially interested in the processing hook specs

@GenevieveBuckley
Copy link

Yes, this would definitely help with discoverability within our community. Thanks for proposing this @jni

@jamadden
Copy link
Member

I was just coming here to add the standard template for Framework classifier requests, and I see that you already found it, and reached out to project maintainers! Thanks for doing the research!

Given what I see here, I would agree that this would be of immediate use and seems notable. I would recommend the classifier for inclusion.

The next step would be to create a PR in this repository adding the classifier. Reference this issue ("fixes #53") in the commit message or PR comment so that the reviewers can see it.

@jamadden
Copy link
Member

D'oh. I see that this is the PR. Sorry, I'm used to people opening issues before PRs.

@jni
Copy link
Contributor Author

jni commented Oct 22, 2020

Wow, that was quick! Thank you so much @jamadden (and @di!) for the one step review! 🎉

jni added a commit to jni/ome-zarr-py that referenced this pull request Oct 23, 2020
This will help napari discover this package as a plugin from the UI, among other things.

Ref:
pypa/trove-classifiers#53
jni added a commit to jni/ome-zarr-py that referenced this pull request Oct 23, 2020
This will help napari discover this package as a plugin from the UI, among other things.

Ref:
pypa/trove-classifiers#53
@Czaki
Copy link

Czaki commented Oct 24, 2020

When it will be accepted by pypi?

@jni
Copy link
Contributor Author

jni commented Oct 25, 2020

@Czaki even though it doesn't yet appear in the online list, the latest release of trove-classifiers, "Canonical source for classifiers on PyPI", includes it. I guess it just needs to propagate through various pipelines?

jni@beastie Sun Oct 25 17:50
 ~/projects/napari (master)
 $ pip install trove-classifiers
Collecting trove-classifiers
  Downloading trove_classifiers-2020.10.21-py3-none-any.whl (12 kB)
Installing collected packages: trove-classifiers
Successfully installed trove-classifiers-2020.10.21
(39)
jni@beastie Sun Oct 25 17:50
 ~/projects/napari (master)
 $ python
Python 3.9.0 | packaged by conda-forge | (default, Oct 14 2020, 22:56:29)
[Clang 10.0.1 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from trove_classifiers import classifiers
>>> 'Framework :: napari' in classifiers
True

@Czaki
Copy link

Czaki commented Oct 25, 2020

@jni I understand, but I try to upload a new version of PartSeg (an application which uses napari) with added this classifier and it was rejected. And I do not know If I should rather wait 1-2 days or postpone adding classifier until the next release.

@di
Copy link
Sponsor Member

di commented Oct 26, 2020

This was deployed to PyPI in pypi/warehouse#8737 and is now availalbe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants