add option to view failure stacktraces #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
force-pushed
the
with-trace
branch
2 times, most recently
from
b49bfcf
to
7c69ebc
Compare
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
gaborbernat
force-pushed
the
with-trace
branch
from
7c69ebc
to
6efd327
Compare
|
Shouldn't this simply be part of if logging.getLogger("filelock").getEffectiveLevel() <= logging.INFO:@gaborbernat ping |
|
I view them as different things, so I prefer the explicit nature of how it's currently 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.