Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to view failure stacktraces #1572

Merged
merged 1 commit into from Feb 11, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Feb 11, 2020

No description provided.

@gaborbernat gaborbernat force-pushed the with-trace branch 2 times, most recently from b49bfcf to 7c69ebc Compare Feb 11, 2020
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit caff265 into pypa:master Feb 11, 2020
33 of 35 checks passed
@gaborbernat gaborbernat deleted the with-trace branch Feb 11, 2020
@EpicWink
Copy link

EpicWink commented Feb 13, 2020

Shouldn't this simply be part of --verbose? Maybe instead of if options.with_traceback: use:

if logging.getLogger("filelock").getEffectiveLevel() <= logging.INFO:

@gaborbernat ping

@gaborbernat
Copy link
Contributor Author

gaborbernat commented Feb 13, 2020

I view them as different things, so I prefer the explicit nature of how it's currently 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants