Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process pth files even if $PYTHONPATH points to site-packages/ #1960

Merged
merged 2 commits into from Oct 1, 2020

Conversation

navytux
Copy link
Contributor

@navytux navytux commented Oct 1, 2020

Fixes #1959

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation (not needed)

@navytux navytux force-pushed the y/pth-vs-PYTHONPATHsite branch from 400f0b7 to 55ec530 Compare Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #1960 into main will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1960      +/-   ##
==========================================
+ Coverage   93.91%   93.93%   +0.02%     
==========================================
  Files          86       86              
  Lines        4237     4237              
==========================================
+ Hits         3979     3980       +1     
+ Misses        258      257       -1     
Flag Coverage Δ
#tests 93.93% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/seed/embed/base_embed.py 98.11% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bdf0f1...414ae22. Read the comment docs.

@gaborbernat gaborbernat merged commit 865af66 into pypa:main Oct 1, 2020
1 check passed
@navytux
Copy link
Contributor Author

navytux commented Oct 1, 2020

Thanks

@navytux navytux deleted the y/pth-vs-PYTHONPATHsite branch Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python2: site .pth files are not processed if PYTHONPATH points to site-packages
2 participants