PIP_FIND_LINKS doesn't cope with spaces, work around with file:// URLs. #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstufft
added a commit
that referenced
this pull request
Jan 19, 2016
PIP_FIND_LINKS doesn't cope with spaces, work around with file:// URLs.
This was referenced Jan 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since I upgraded
virtualenvI have been unable to use it. Similar problems have been reported in #524 and #807. It turns out the problem is caused byvirtualenvusingpipto installsetuptools,pipandwheelin the virtual environment. It uses thePIP_FIND_LINKSenvironment variable to directpipto find the tools from thevirtualenvinstallation.PIP_FIND_LINKScan contain multiple space-separated paths or URL links. Because of that, none of the links can contain spaces. However, ifvirtualenvis installed to a path containing spaces,PIP_FIND_LINKSwould have to contain a path with spaces, e.g.:To work around this
piplimitation, local paths can be converted to file:// URLs which don't have any literal spaces. The conversion is done only for paths actually containing spaces.There is an alternative PR in #823. I think it's less elegant, more complex and solves the problem only for Windows users, and only for those Windows users who have short-name generation enabled. However, the root problem is not OS specific.