Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install g++ from a PPA in travis #3037

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Don't install g++ from a PPA in travis #3037

merged 2 commits into from
Feb 23, 2018

Conversation

alex
Copy link
Member

@alex alex commented Feb 23, 2018

I have no idea if this will work

@alex alex changed the title Test removing g++ installation Don't install g++ from a PPA in travis Feb 23, 2018
@alex
Copy link
Member Author

alex commented Feb 23, 2018

The default C++ compiler appears just fine.

This speeds up the tests by a bit.

@alex alex requested a review from ewdurbin February 23, 2018 03:27
@ewdurbin
Copy link
Member

🙏 bless you!

@ewdurbin
Copy link
Member

for record keeping: these were added in #1137 and appear to have been in support of some node dependencies for static builds. it looks like brotli may not have worked with older compilers... but we're good now :)

@ewdurbin
Copy link
Member

particularly as we don't actually use any assets from travis for deployment, I'm gonna say 🚀

@ewdurbin ewdurbin merged commit c2c9511 into master Feb 23, 2018
@ewdurbin ewdurbin deleted the alex-patch-1 branch February 23, 2018 03:36
dstufft added a commit that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants