Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add more testing for the wheel filename regex #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jacobdr
Copy link

@jacobdr jacobdr commented Nov 5, 2022

Following on from #485, this expands on the tests added in 4419390 to include more variations and, more importantly, tests the returned group portions of the regex

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 68.28% // Head: 68.28% // No change to project coverage 👍

Coverage data is based on head (f6a525d) compared to base (4419390).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   68.28%   68.28%           
=======================================
  Files          12       12           
  Lines         927      927           
=======================================
  Hits          633      633           
  Misses        294      294           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jacobdr
Copy link
Author

jacobdr commented Nov 5, 2022

@agronholm I think you are best suited to be the reviewer here as you had the commit to add the testing and fix the regression. Let me know if this suits. I can back out the virtualenv .gitignore change since that is not strictly required here

@jacobdr
Copy link
Author

jacobdr commented Nov 7, 2022

@agronholm I saw your comment about the regex going away in 1.0 in deference to packaging, so I opened pypa/packaging#608 on that side as well with a similar test change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant