Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings file: avoid definition line comments #215

Closed
mara004 opened this issue Apr 27, 2023 · 1 comment
Closed

bindings file: avoid definition line comments #215

mara004 opened this issue Apr 27, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mara004
Copy link
Member

mara004 commented Apr 27, 2023

Since #192 / #196, we have a reference bindings file in the repository.
However, each time pdfium headers change, definition lines may shift (as seen in 0c1a20d).
We don't want this to blow up the repository's history unnecessarily.
See if we can make ctypesgen skip these needless line comments.

@mara004 mara004 added the enhancement New feature or request label Apr 27, 2023
@mara004 mara004 self-assigned this Apr 27, 2023
@mara004
Copy link
Member Author

mara004 commented Apr 27, 2023

Hmm, I have a patch adding an option for this to ctypesgen, but using the option in pypdfium2 would mean to break compatibility with mainline ctypesgen...
Apart from that, we need to revisit how our ctypesgen fork is managed, for I'm not able to isolate that latest patch into an independent branch as it interferes with both the argparse and strings patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant