Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring to better support numpy v2 changes #529

Merged
merged 8 commits into from
Aug 11, 2024

Conversation

briochh
Copy link
Collaborator

@briochh briochh commented Aug 8, 2024

  • refactoring reading of list like files to support preserving index col type where it might be mixed -- and casting to int where needed.
  • refactoring other pstfrom methods to preserve model file datatypes under numpy 2 -- removing reliance on sidx (which wasn't stored well in csv under numpy2) to align pars during the apply methods. Instead use index_col values directly.
  • updated tests
  • np.NaN changed to np.nan
  • Fixing pstfrom add_pars to make better used of x and y or i and j in index cols.
  • Unpinning numpy

@coveralls
Copy link

coveralls commented Aug 8, 2024

Coverage Status

coverage: 79.412% (+0.07%) from 79.346%
when pulling 88dacc3 on briochh:hotfix_numpy2
into 5551e16 on pypest:numpy2.

@briochh briochh merged commit fb250b9 into pypest:numpy2 Aug 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants