Add seasoning #123
Merged
Add seasoning #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should not impact existing behaviors, rather start passing the hashed value to the backend.
Based loosely on https://developer.fastly.com/reference/vcl/variables/geolocation/client-geo-region-ascii/ Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
commented
Apr 3, 2023
dstufft
reviewed
Apr 3, 2023
Simpler logic, as we are not building strings. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
ewdurbin
approved these changes
Apr 7, 2023
ewdurbin
force-pushed
the
miketheman/seasoning
branch
from
4890b45
to
fddd914
Compare
di
approved these changes
Apr 7, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes some new headers tasty.
Needs some extra 👀 and validation - I'm not certain how this gets rolled out to test before prod