Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added search to each page #126

Merged
merged 4 commits into from
Jun 27, 2023
Merged

added search to each page #126

merged 4 commits into from
Jun 27, 2023

Conversation

saip007
Copy link
Contributor

@saip007 saip007 commented Jun 26, 2023 •
edited by di
Loading

  • added search to base.html
  • removed from index.html

Closes #121

@saip007 saip007 changed the title added search to base.html, removed from index.html, made necessary ch… added search to each page Jun 26, 2023
@saip007 saip007 mentioned this pull request Jun 26, 2023
Closed
di
di reviewed Jun 26, 2023
View reviewed changes
inspector/main.py Outdated Show resolved Hide resolved
inspector/templates/base.html Outdated Show resolved Hide resolved
inspector/templates/disasm.html Outdated Show resolved Hide resolved
@saip007
Copy link
Contributor Author

saip007 commented Jun 27, 2023 •
edited
Loading

Ok I'll update the code again

@saip007
Copy link
Contributor Author

saip007 commented Jun 27, 2023

Modified the code according to your commits, you may review the code again

@saip007 saip007 requested a review from di June 27, 2023 11:49
di
di reviewed Jun 27, 2023
View reviewed changes
inspector/templates/disasm.html Outdated Show resolved Hide resolved
inspector/templates/disasm.html Outdated Show resolved Hide resolved
@di di merged commit 3748a95 into pypi:main Jun 27, 2023
@di
Copy link
Member

di commented Jun 27, 2023

Thanks!

@saip007
Copy link
Contributor Author

saip007 commented Jul 18, 2023

Hi @di,
I noticed that the changes I made hadn't been published. Could you please provide an update on their status? Is there anything else I could do to make sure they're included?

@di
Copy link
Member

di commented Jul 18, 2023

Looks like this accidentally got removed in #135, @AngeloD2022 could you make a PR to add it back?

@AngeloD2022
Copy link
Contributor

Looks like this accidentally got removed in #135, @AngeloD2022 could you make a PR to add it back?

Yes absolutely. My apologies! I will make a PR when I can today.

@saip007
Copy link
Contributor Author

saip007 commented Jul 18, 2023

Thanks @di & @AngeloD2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Search Button to Each Page for Easy Package Navigation
3 participants
@saip007 @di @AngeloD2022