feat: use geoip info for display #13745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
force-pushed
the
miketheman/location-info
branch
2 times, most recently
from
1a054ce
to
99d80c0
Compare
Basic implementation of pulling the GeoIP info off `Event.additional` Needs test cases, as well as refining the display order of values. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/location-info
branch
from
99d80c0
to
6cc494f
Compare
miketheman
commented
May 25, 2023
| @@ -183,14 +183,14 @@ def test_acl(self, db_session): | |||
| key=lambda x: x[1], | |||
| ) | |||
|
|
|||
| def test_record_event(self, db_request): | |||
| def test_record_event_with_geoip(self, db_request): | |||
There was a problem hiding this comment.
thought: for a future refactor, I'm thinking these test cases should be split out to events/test_models.py, but I wanted to defer that for now, since there's some complexity in creating a subclassed fakeish db model
ewdurbin
approved these changes
May 25, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of pulling the GeoIP info off
Event.additional