Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of GitLab statistics #15931

Merged
merged 10 commits into from
Sep 19, 2024
Merged

Initial implementation of GitLab statistics #15931

merged 10 commits into from
Sep 19, 2024

Conversation

nE0sIghT
Copy link
Contributor

@nE0sIghT nE0sIghT commented May 9, 2024

Issue: #12789

@nE0sIghT nE0sIghT requested a review from a team as a code owner May 9, 2024 20:42
@di
Copy link
Member

di commented Jul 3, 2024

Thanks for the PR! It looks great, but I'm going to hold off on fully reviewing/merging this until #8635 is resolved for GitLab URLs, so we don't run into the same issue as we have for GitHub.

@nE0sIghT
Copy link
Contributor Author

nE0sIghT commented Jul 3, 2024

#16205 looks good! I will follow it and work on Gitlab part if needed

@nE0sIghT
Copy link
Contributor Author

Hello!

Do I need to rebase this PR or either merge main branch here?

@di
Copy link
Member

di commented Aug 13, 2024

@nE0sIghT Hang tight, I suspect the next part of #8635 that we will resolve will be verifying the GitHub statistics, after which we can get this up to date. Thanks for your patience!

@nE0sIghT
Copy link
Contributor Author

Could we proceed with this PR? I can rebase or merge main branch here

@di
Copy link
Member

di commented Sep 10, 2024

Sorry, I meant to comment here that this is unblocked now that #16532 is merged. Please feel free to proceed!

@nE0sIghT
Copy link
Contributor Author

Thanks! Should I merge or rebase?

@di
Copy link
Member

di commented Sep 10, 2024

Either is fine, we do squash merging so it doesn't make much difference.

@nE0sIghT
Initial implementation of GitLab statistics
b16a1be 
Issue: pypi#12789
Signed-off-by: Yuri Konotopov <ykonotopov@gnome.org>
@nE0sIghT
Copy link
Contributor Author

nE0sIghT commented Sep 10, 2024 •
edited
Loading

I rebased PR on top of the main branch, added unit tests and tested locally

image

@nE0sIghT
Copy link
Contributor Author

Thanks for review! I pushed new commits that should address mentioned issues.

di
di approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@di
Copy link
Member

di commented Sep 18, 2024

@nE0sIghT Can you resolve the merge conflicts here? Thanks

@nE0sIghT
Copy link
Contributor Author

Can you resolve the merge conflicts here?

It's done

@nE0sIghT
Copy link
Contributor Author

project-data.html in the message.pot is popular :-) Should I merge main branch again?

@di
Copy link
Member

di commented Sep 19, 2024

Sorry, we have been sorting out some issues there recently :) Yes please, should be the last time!

@di di merged commit dccf3ee into pypi:main Sep 19, 2024
18 checks passed
@di di mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nE0sIghT @di