-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warehouse: PEP 740 models #16625
warehouse: PEP 740 models #16625
Conversation
This is a breakout from pypi#16624, to reduce the complexity/headache of zippered reverts. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
I added a simple test and Factory in 34ec661 that can easily be reverted if needed. However, just thinking out loud here, I think we should also have a The current design forces us to keep a forward-compatible version of the Provenance object to use the opaque JSON object with a |
I might be under-thinking it, but I don't think this will be an issue -- if we need to roll the provenance version forwards, we can always do something like (But also, if we need to bump the version, we can always add a |
tests/common/db/attestations.py
Outdated
provenance = {} | ||
provenance_digest = factory.LazyAttribute( | ||
lambda o: hashlib.sha256(o.file.filename.encode("utf8")).hexdigest() | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breakout from #16624,
to reduce the complexity/headache of zippered reverts.
Signed-off-by: William Woodruff william@trailofbits.com