chore: remove obsolete csp header #16664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in #1105. > It is now obsolete, because all mixed content is now blocked if it can’t be autoupgraded. Refs: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/block-all-mixed-content Refs: https://www.w3.org/TR/mixed-content/#strict-checking Signed-off-by: Mike Fiedler <miketheman@gmail.com>
ewdurbin
approved these changes
Sep 9, 2024
|
Seems fine given docs, but is there harm in leaving it? I'm curious how this impacts older browsers that may have been enforcing the directive. |
|
The harm I can currently conceive is that we emit a small amount of extra bytes in every header, and browsers like Firefox emit a warning. The standard appears to try to have browsers upgrade insecure by default, and block anything not upgradable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #1105.
Refs: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/block-all-mixed-content
Refs: https://www.w3.org/TR/mixed-content/#strict-checking