Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyramid-tm to 2.2 #2166

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Conversation

pyup-bot
Copy link
Contributor

@pyup-bot pyup-bot commented Jul 3, 2017

There's a new version of pyramid-tm available.
You are currently using 2.1. I have updated it to 2.2

These links might come in handy: PyPI | Changelog | Homepage

Changelog

2.2

^^^^^^^^^^^^^^^^

Backward Incompatibilities

  • This is a backward-incompatible change for anyone using the
    tm.commit_veto hook. Anyone else is unaffected.

The tm.commit_veto hook will now be consulted for any squashed
exceptions instead of always aborting. Previously, if an exception
was handled by an exception view, the transaction would always be aborted.
Now, the commit_veto can inspect request.exception and the generated
response to determine whether to commit or abort.

The new behavior when using the pyramid_tm.default_commit_veto is that
a squashed exception may be committed if either of the following conditions
are true:

  • The response contains the x-tm header set to commit.
  • The response's status code does not start with 4 or 5.

In most cases the response would result in 4xx or 5xx exception and would
be aborted - this behavior remains the same. However, if the squashed
exception rendered a response that is 3xx or 2xx (such as raising
pyramid.httpexceptions.HTTPFound), then the transaction will be
committed instead of aborted.

See Pylons/pyramid_tm#65

Got merge conflicts? Close this PR and delete the branch. I'll create a new PR for you.

Happy merging! 🤖

@dstufft dstufft merged commit 3932438 into master Jul 3, 2017
@dstufft dstufft deleted the pyup-update-pyramid-tm-2.1-to-2.2 branch July 3, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants