Add email templates for removed file from release #7498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MVrachev
force-pushed
the
remove-version-file-email
branch
from
0c476ff
to
6a171e5
Compare
di
reviewed
Mar 5, 2020
warehouse/templates/email/removed-project-release-file/subject.txt
Outdated
Show resolved
Hide resolved
MVrachev
force-pushed
the
remove-version-file-email
branch
from
6a171e5
to
0fd9d31
Compare
|
I updated my pr addressing your comment @di. |
di
reviewed
Mar 10, 2020
warehouse/templates/email/removed-project-release-file/body.html
Outdated
Show resolved
Hide resolved
warehouse/templates/email/removed-project-release-file/body.txt
Outdated
Show resolved
Hide resolved
warehouse/templates/email/removed-project-release-file/body.html
Outdated
Show resolved
Hide resolved
warehouse/templates/email/removed-project-release-file/body.txt
Outdated
Show resolved
Hide resolved
warehouse/templates/email/removed-project-release-file/subject.txt
Outdated
Show resolved
Hide resolved
MVrachev
force-pushed
the
remove-version-file-email
branch
from
0fd9d31
to
db8dcef
Compare
|
Thank you for the comprehensive and detailer review @di! |
MVrachev
commented
Mar 12, 2020
di
requested changes
Mar 17, 2020
MVrachev
force-pushed
the
remove-version-file-email
branch
from
db8dcef
to
6c0c8b7
Compare
|
Removed translations for |
di
requested changes
Mar 19, 2020
warehouse/templates/email/removed-project-release-file/body.html
Outdated
Show resolved
Hide resolved
warehouse/templates/email/removed-project-release-file/body.html
Outdated
Show resolved
Hide resolved
warehouse/templates/email/removed-project-release-file/body.html
Outdated
Show resolved
Hide resolved
Until now, when there are multiple contributors on a single the project, if one of them deletes a file from certain release the other contributors don't get any notification, which is problematic. Connected with issue pypi#5714 Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
force-pushed
the
remove-version-file-email
branch
from
6c0c8b7
to
4a25fc6
Compare
|
Removed all translations. |
di
approved these changes
Mar 20, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, when there are multiple contributors on a single
the project, if one of them deletes a file from certain release
the other contributors don't get any notification,
which is problematic.
Connected with issue #5714
Signed-off-by: Martin Vrachev mvrachev@vmware.com