Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve URLs parsing #7565

Merged
merged 3 commits into from Mar 19, 2020
Merged

Improve URLs parsing #7565

merged 3 commits into from Mar 19, 2020

Conversation

orsinium
Copy link
Contributor

@orsinium orsinium commented Mar 19, 2020

A few small non-breaking changes to make Release.urls parsing a bit more readable and reliable. The most important thing is replacing split to partition to handle cases with missed link name:

  • Example,https://exampe.com - correct
  • ,https://exampe.com - ignore
  • https://exampe.com - ignore

Tests inside

@di di merged commit 6eda363 into pypi:master Mar 19, 2020
1 check passed
@di
Copy link
Member

di commented Mar 19, 2020

Thanks!

@orsinium orsinium deleted the simplify-urls branch Mar 19, 2020
@brainwane
Copy link
Contributor

brainwane commented Apr 3, 2020

@orsinium Thank you so much for working on this! If you would like suggestions for another issue that could use your help, please let us know by replying.

@orsinium
Copy link
Contributor Author

orsinium commented Apr 6, 2020

Thank you for the quick review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants